Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have jq-console work without JQuery. #76

Open
elvongray opened this issue Oct 11, 2015 · 3 comments
Open

Have jq-console work without JQuery. #76

elvongray opened this issue Oct 11, 2015 · 3 comments

Comments

@elvongray
Copy link

Although this is clearly a jQuery plugin, I was wondering if there are plans to have this plugin work without jQuery. Example of a project that have this feature masonry

@arichiardi
Copy link
Contributor

👍 I asked exactly the same in some issue/PR
I am also tempted to fork it in order to add the autoscroll switch.

@arichiardi
Copy link
Contributor

I have grepped around 30 usages of $(, the constructor without jQuery is an easy fix, e.g. expose the JQConsole vanilla constructor like in:

// vanilla JS
var grid = document.querySelector('.grid');
var msnry = new Masonry( grid, {
  // options...
  itemSelector: '.grid-item',
  columnWidth: 200
});

@amasad
Copy link
Contributor

amasad commented Oct 12, 2015

Masonry doesn't seem to be using jQuery internally, in our case we are using it extensively. It's going to be a lot harder for us to port this to vanilla JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants