Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package contains incorrect path to ReportPortal.conf file #17

Closed
nvborisenko opened this issue Aug 30, 2018 · 4 comments
Closed

Comments

@nvborisenko
Copy link
Member

We need remove this file from package. User will add it manually.

@nvborisenko nvborisenko self-assigned this Aug 30, 2018
@fjody
Copy link

fjody commented Aug 30, 2018

image
When I would like to delete it in Visual Studio, it doesn't want to allow me.
(issue was told to Mikalai)

@nvborisenko
Copy link
Member Author

The issue is reproducible only for PackageReference projects, this is new csproj format. Nuget adds ReportPortal.conf file into project by global cache path. It's not bad, user still is able to edit file, but these changes are per user machine. Not acceptable for us.
There are 2 ways to resolve it:

Cannot make a decision yet which way is better, let's wait more impacted users.

@nvborisenko
Copy link
Member Author

Decided to remove this file from package. User should manually add it to a test project. We will provide a json schema. In future we can provide additional package to install config file.

@nvborisenko
Copy link
Member Author

Fixed in v3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants