Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support comparing multi-node image vs single-node image #5

Closed
AkihiroSuda opened this issue Aug 23, 2023 · 1 comment
Closed

Support comparing multi-node image vs single-node image #5

AkihiroSuda opened this issue Aug 23, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@AkihiroSuda
Copy link
Member

Currently the comparison fails before comparing the actual layers

$ docker build -t my-golang-1.21-alpine3.18 'https://github.com/docker-library/golang.git#master:1.21/alpine3.18'
$ diffoci diff golang:1.21-alpine3.18 docker://my-golang-1.21-alpine3.18 --verbose --semantic
INFO[0000] Loading image "docker.io/library/my-golang-1.21-alpine3.18:latest" from "docker" 
docker.io/library/my golang 1.21 alpine3	saved	
Importing	elapsed: 1.1 s	total:   0.0 B	(0.0 B/s)	
Event: "DescriptorMismatch"
  &v1.Descriptor{
  	MediaType: strings.Join({
  		"application/vnd.docker.distribution.manifest.",
- 		"list.",
  		"v2+json",
  	}, ""),
  	... // 4 ignored and 3 identical fields
  }

Event: "DescriptorMismatch" (field "Annotations")
  map[string]string(
- 	nil,
+ 	{
+ 		"io.containerd.image.name":          "docker.io/library/my-golang-1.21-alpine3.18:latest",
+ 		"org.opencontainers.image.ref.name": "latest",
+ 	},
  )

Event: "IndexBlobMismatch"
  v1.Index{
  	Versioned: {SchemaVersion: 2},
  	MediaType: strings.Join({
  		"application/vnd.docker.distribution.manifest.",
- 		"list.",
  		"v2+json",
  	}, ""),
  	ArtifactType: "",
  	... // 3 ignored fields
  }

Event: "IndexBlobMismatch" (field "Manifests": length mismatch)
@AkihiroSuda AkihiroSuda added the enhancement New feature or request label Aug 23, 2023
@AkihiroSuda
Copy link
Member Author

Experimentally implemented in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant