We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise.prototype.finally is introduced in ES2018, but the README indicates that it is "not available".
Promise.prototype.finally
The text was updated successfully, but these errors were encountered:
+1
Sorry, something went wrong.
This nearly stopped me from using this library 😬
Thanks @KamasamaK for confirming
added a pr: #46
I just merged @tbjgolden ’s PR #46 which clarifies this. With node v10 and above you can write these:
rp(...) .then(...) .catch(...) .finally(...)
rp(...) .catch(...) .finally(...)
rp(...) .then(...) .finally(...)
But not:
rp(...) .finally(...)
Until the direct finally call is supported, you can use:
finally
rp(...).promise() .finally(...)
I leave this issue open until that last case without using .promise() is supported as well.
.promise()
No branches or pull requests
Promise.prototype.finally
is introduced in ES2018, but the README indicates that it is "not available".The text was updated successfully, but these errors were encountered: