Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge US_acquisition on staging #775

Merged
merged 18 commits into from
Dec 21, 2021
Merged

Merge US_acquisition on staging #775

merged 18 commits into from
Dec 21, 2021

Conversation

zannkukai
Copy link
Contributor

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

zannkukai and others added 18 commits December 20, 2021 14:48
* Creates a `acquisition` module.
* Moves legacy components/services related to acquisition features into
  this new module.
* Creates pages to list acquisition accounts using a tree view to
  respect accounts hierarchy.
* Creates form to transfer funds between two accounts.
* Corrects linting warning problems.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Creates a formly widget especially for `AcqAccount` resource. This
widget will generate a hierarchical dropdown list with a remaining
balance statement.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Updates order detail/brief views.
* Adds facet and sort filters on orders result view.
* Fixed orders brief/detail view.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Updates the library custom editor to allow specify acquisition
  settings.
* Updates the library detail view to display acquisition settings in a
  new tab.
* Fixes deprecated Jasmine uni tests.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Improves account detail view.
* Improves orders detail view.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Creates the modal component to display the preview.
* Create service API to sent the order
* Update the order display after order sent (to see updated status)

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Create a component to display the order summary.
* Updates copyright dates for acquisition module files.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Limit access to update actions (add/edit/delete) if the current user
isn't connected with the owning resource library.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Fixes order update guard.
* Fixes send order `reply_to` address.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Updates item counter into the order brief views.
* Adds display of item ordered counter and item received counter into
  the order summary component.
* Fix CSS about `btn-show-more` class if included into a card section.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
In order to list all receipts related to an order, a new `Reception` tab
is now present into the order detail view. In this tab we list all
receipts related to an order.

Updates the display of order reception form to improve the user
experience.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Adds a component to display all details about a receipt.
* Refactors acquisition modules services : removes generic services to
  keep only API services ; removes all unnecessary classes in favor of
  corresponding interfaces (lighter for memory usage).
* Adapts accounting informations display.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Add the account number/reference into the option list to help manager to
choose the correct account when adding an order line or an additional
fee (for reception).

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Adds options for show or hide trash on repeat section.
* Adds a checkbox to selected record.
* Adds a new field vat rate on order line.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
* Updates receipt form display for a vertical alignment to allow more
  spaces for input fields.
* Fixes some typo.
* Create a pipe to compute the reception line total amount.
* Improves some cascading styles for a better display.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Update the library custom editor to allow management of new `extra`
  field available for any acquisition setting section.
* Updates the library detail view to display this new field.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai self-assigned this Dec 21, 2021
@github-actions github-actions bot added f: acquisitions Related to the acquisition module f: activity-logs Everything around logging user activities f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface labels Dec 21, 2021
@zannkukai zannkukai merged commit 4241991 into staging Dec 21, 2021
@zannkukai zannkukai deleted the US_acquisition branch January 24, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: acquisitions Related to the acquisition module f: activity-logs Everything around logging user activities f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants