Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request menu don't display the pickup_name field #170

Closed
iGormilhit opened this issue Jan 9, 2019 · 2 comments
Closed

Request menu don't display the pickup_name field #170

iGormilhit opened this issue Jan 9, 2019 · 2 comments
Labels
bug (critical) Blocking issue, should be fixed ASAP

Comments

@iGormilhit
Copy link

iGormilhit commented Jan 9, 2019

On the master branch (c8c2fa4), when a connected patron wants to request an available item (or an unavailable item), the request menu shows only one pickup location named "Espaces publics".

The pickup_name should be used, and all available pickup locations should be displayed, not only the one that owns the item.

As @BadrAly mentionned on Gitter, the library name should be displayed, instead of the pickup location name.

Code: https://github.com/rero/rero-ils/blob/master/rero_ils/modules/documents_items/templates/rero_ils/detailed_view_documents_items.html#L200

Print screens:

capture_158

capture_159

@iGormilhit iGormilhit added bug bug (critical) Blocking issue, should be fixed ASAP labels Jan 9, 2019
@iGormilhit
Copy link
Author

The same issue occurs on the patron profile view, in the pending tab, 3rd column (pickup library).

@iGormilhit
Copy link
Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug (critical) Blocking issue, should be fixed ASAP
Projects
None yet
Development

No branches or pull requests

1 participant