Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation before submitting an ILL request #1771

Closed
pronguen opened this issue Mar 15, 2021 · 3 comments
Closed

Confirmation before submitting an ILL request #1771

pronguen opened this issue Mar 15, 2021 · 3 comments
Labels
enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.2.0

Comments

@pronguen
Copy link
Contributor

How it works

Currently, the "ENTER" key submits the ILL request, even if only the title has been entered. Then, the patron cannot edit this request anymore.

Improvement suggestion

Ideally, the "ENTER" key submits the request, but a confirmation pop-up is opened: "Do you want to submit this request".
The patron can choose "Confirm" (call to action) or "Cancel" (outline, red).
@pronguen pronguen added enhancement Improvement of an existing feature triage p-Medium Medium priority (to be solved within 1-2 years) labels Mar 15, 2021
@pronguen pronguen mentioned this issue Mar 15, 2021
Closed
@iGormilhit iGormilhit changed the title Validation of ILL request before submitting (public interface) Confirmation before submitting an ILL request Apr 26, 2021
@iGormilhit iGormilhit added f: public ui Public interface, as opposed to the professional interface and removed triage labels Apr 26, 2021
@iGormilhit iGormilhit added this to the v1.2.0 milestone Apr 26, 2021
@iGormilhit
Copy link

even if only the title has been entered

To allow this behavior, no other fields have been defined as required.

@zannkukai zannkukai self-assigned this Apr 27, 2021
@zannkukai
Copy link
Contributor

It seems that a confirmation box is already present on submit button and when the enter key is fired :
image

implemented by @jma 2021/03/16.
Is it suffisent ?

@zannkukai zannkukai removed their assignment Apr 27, 2021
@pronguen
Copy link
Contributor Author

@zannkukai You're right! I close it. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
3 participants
@iGormilhit @pronguen @zannkukai