Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "City" facet of the patron search relies on the wrong field #1949

Closed
pronguen opened this issue May 26, 2021 · 3 comments · Fixed by #1990
Closed

The "City" facet of the patron search relies on the wrong field #1949

pronguen opened this issue May 26, 2021 · 3 comments · Fixed by #1990
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking effort: minor Solved quickly f: professional ui Professional interface f: search f: user management p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.4.0

Comments

@pronguen
Copy link
Contributor

Describe the bug

The facet relies on the city of the secondary address.

To Reproduce

  1. Open https://ilspilot.test.rero.ch/professional/records/patrons?q=&page=1&size=10
  2. Look at the "City" facet

Expected behavior

It should rely on the city of the primary address.

Context

  • server: ilspilot.test.rero.ch
  • version: v1.2.0
@pronguen pronguen added effort: minor Solved quickly f: professional ui Professional interface triage bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) labels May 26, 2021
@zannkukai
Copy link
Contributor

Now, the facet is based on facet_city ES field. This field is populated from "primary address city" and "secondary address city". We can only index "primary city" without any problem in the facet. Is it the expected behavior ?

@pronguen
Copy link
Contributor Author

pronguen commented Jun 7, 2021

The facet seems to be populated only by the "secondary address city":

https://ilspilot.test.rero.ch/professional/records/patrons?q=nicolas%20prongu%C3%A9&page=1&size=10
image

Expected behaviour:

  • at least primary address city
  • we can also keep the secondary address city

@zannkukai zannkukai self-assigned this Jun 7, 2021
@zannkukai zannkukai added this to the v1.4.0 milestone Jun 7, 2021
@iGormilhit iGormilhit changed the title User brief view: the "City" facet relies on the wrong field The "City" facet of the patron search relies on the wrong field Jun 8, 2021
@iGormilhit iGormilhit linked a pull request Jun 8, 2021 that will close this issue
patrons: correct city facet mapping #1990
Merged
7 tasks
@iGormilhit
Copy link

Closed by #1990.

@zannkukai zannkukai mentioned this issue Jan 17, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking effort: minor Solved quickly f: professional ui Professional interface f: search f: user management p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

patrons: correct city facet mapping zannkukai/rero-ils
3 participants
@iGormilhit @pronguen @zannkukai