Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two API requests for on search query on the global search #1970

Closed
iGormilhit opened this issue Jun 2, 2021 · 1 comment · Fixed by #2186
Closed

Two API requests for on search query on the global search #1970

iGormilhit opened this issue Jun 2, 2021 · 1 comment · Fixed by #2186
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking f: search p-Medium Medium priority (to be solved within 1-2 years) performance
Milestone
v1.5.0

Comments

@iGormilhit
Copy link

Describe the bug

As a user enter a search query on the global page search, two API requests occur, thus doubling the loading time of the page.

To Reproduce

  1. Go to the global search
  2. Enter an empty search
  3. Inspect the network
  4. See error

Expected behavior

Only one API request should be made.

Context

Screenshots

ksnip_20210602-105504
@iGormilhit iGormilhit added triage bug Breaks something but is not blocking performance f: search and removed triage labels Jun 2, 2021
@iGormilhit iGormilhit added this to the v1.4.0 milestone Jun 2, 2021
@Garfield-fr Garfield-fr self-assigned this Jun 8, 2021
@iGormilhit iGormilhit added the p-Medium Medium priority (to be solved within 1-2 years) label Jun 23, 2021
@iGormilhit iGormilhit modified the milestones: v1.4.0, v1.5.0 Jul 5, 2021
@iGormilhit iGormilhit linked a pull request Jul 19, 2021 that will close this issue
search: add an option to limit the i18n_aggs #2186
Merged
7 tasks
@iGormilhit
Copy link
Author

Fixed by #2186.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking f: search p-Medium Medium priority (to be solved within 1-2 years) performance
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

search: add an option to limit the i18n_aggs jma/rero-ils
2 participants
@Garfield-fr @iGormilhit