Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong availability for item_type "no checkout" #209

Closed
iGormilhit opened this issue Mar 7, 2019 · 6 comments
Closed

Wrong availability for item_type "no checkout" #209

iGormilhit opened this issue Mar 7, 2019 · 6 comments
Labels
bug (critical) Blocking issue, should be fixed ASAP

Comments

@iGormilhit
Copy link

Items with item_type.pid:4 are displayed as available, but the item_type is "No Checkout", which is associate with circulation policy 8, "No checkout".

capture_169

Item type 4:

{
    "$schema": "https://ils.rero.ch/schema/item_types/item_type-v0.0.1.json",
    "description": "No checkout.",
    "name": "No checkout",
    "organisation": {
      "$ref": "https://ils.rero.ch/api/organisations/1"
    },
    "pid": "4"
  }

Circulation policy 8:

{
    "$schema": "http://ils.rero.ch/schema/circ_policies/circ_policy-v0.0.1.json",
    "allow_checkout": false,
    "allow_requests": false,
    "description": "No checkout.",
    "is_default": false,
    "name": "No checkout",
    "organisation": {
      "$ref": "https://ils.rero.ch/api/organisations/1"
    },
    "pid": "8",
    "policy_library_level": false,
    "settings": [
      {
        "item_type": {
          "$ref": "https://ils.rero.ch/api/item_types/4"
        },
        "patron_type": {
          "$ref": "https://ils.rero.ch/api/patron_types/1"
        }
      },
      {
        "item_type": {
          "$ref": "https://ils.rero.ch/api/item_types/4"
        },
        "patron_type": {
          "$ref": "https://ils.rero.ch/api/patron_types/3"
        }
      },
      {
        "item_type": {
          "$ref": "https://ils.rero.ch/api/item_types/5"
        },
        "patron_type": {
          "$ref": "https://ils.rero.ch/api/patron_types/3"
        }
      },
      {
        "item_type": {
          "$ref": "https://ils.rero.ch/api/item_types/6"
        },
        "patron_type": {
          "$ref": "https://ils.rero.ch/api/patron_types/3"
        }
      }
    ]
  }
@iGormilhit iGormilhit added bug (critical) Blocking issue, should be fixed ASAP UI labels Mar 7, 2019
@BadrAly
Copy link

BadrAly commented Mar 11, 2019

Should be fixed after merging #210

@iGormilhit
Copy link
Author

@BadrAly Very nice! If true, could you add in the commit message:
* FIX Fixes #209
Thanks, and sorry for the annoyance.

@iGormilhit
Copy link
Author

@BadrAly I don't think that #210 is fixing this issue:

capture_170

@BadrAly
Copy link

BadrAly commented Mar 11, 2019

Correction:
The circulation policy controls the display of the request button. This part is working.
The current logic is : An item is available if it has a status on_shelf and has no requests. (no relations with item type + patron type)

@iGormilhit
Copy link
Author

iGormilhit commented Mar 11, 2019

@iGormilhit
Copy link
Author

Fixed by #491.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug (critical) Blocking issue, should be fixed ASAP
Projects
None yet
Development

No branches or pull requests

2 participants