entity: better replace_identified_by #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rerowep
commented
Oct 24, 2023
rerowep
commented
- Corrects handling of rero only and not found identifiers.
rerowep
force-pushed
the
wep-better_replace_identified_by
branch
2 times, most recently
from
0745b02 to
f797e8c
Compare
* Corrects handling of rero only and not found identifiers. Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep
force-pushed
the
wep-better_replace_identified_by
branch
from
f797e8c to
4670f9f
Compare
rerowep
requested review from
jma,
zannkukai,
lauren-d,
PascalRepond and
Garfield-fr
Garfield-fr
approved these changes
Oct 25, 2023
lauren-d
approved these changes
Oct 25, 2023
PascalRepond
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.