Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make multiple affiliation processing more robust #824

Open
mmo opened this issue Apr 12, 2022 · 3 comments
Open

Make multiple affiliation processing more robust #824

mmo opened this issue Apr 12, 2022 · 3 comments
Labels
client request effort: important US candidate stale Stale or no longer relevant

Comments

@mmo
Copy link
Collaborator

mmo commented Apr 12, 2022 •
edited
Loading

Describe the issue

Swiss affiliations are currently stored in a CSV file affiliations.csv, which implies some name matching limitations.

What should be done?

Store Swiss affiliations in a JSON file, with a controlled_affiliation record per Swiss affiliation, containing:

  • short_name (string)
  • alternative_names (array of strings)
  • rejected_names (array of strings)

The field rejected_names allows to avoid collisions between institutions with similar names, such as "Zurich University" (UniZH) and "Zurich University of the Arts" (ZHdK). Currently, authors with "Zurich University of the Arts" in their affiliation, are assigned to both institutions, which is wrong. (A temporary fix has been added to the code for handling this special case in sonar/affiliations/affiliation_resolver.py.)
@mmo mmo added developers From a developer point of view. p-Low To set a low priority. labels Apr 12, 2022
@mmo mmo changed the title Make multiple affiliations processing more robust Make multiple affiliation processing more robust Apr 12, 2022
@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Oct 10, 2022
@PascalRepond PascalRepond removed the stale Stale or no longer relevant label Oct 17, 2022
@PascalRepond PascalRepond reopened this Oct 17, 2022
@PascalRepond PascalRepond added client request and removed p-Low To set a low priority. developers From a developer point of view. labels Apr 4, 2023
@PascalRepond PascalRepond moved this to Inbox in SONAR issues Apr 4, 2023
@PascalRepond PascalRepond mentioned this issue Apr 4, 2023
Closed
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Oct 2, 2023
@github-actions github-actions bot closed this as completed Oct 2, 2023
@github-project-automation github-project-automation bot moved this from Inbox to Done in SONAR issues Oct 2, 2023
@PascalRepond PascalRepond removed the stale Stale or no longer relevant label Oct 2, 2023
@PascalRepond PascalRepond reopened this Oct 2, 2023
@github-project-automation github-project-automation bot moved this from Done to Product Backlog in SONAR issues Oct 2, 2023
@PascalRepond PascalRepond moved this from Product Backlog to Inbox in SONAR issues Oct 23, 2023
@PascalRepond PascalRepond added the effort: important US candidate label Nov 28, 2023
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client request effort: important US candidate stale Stale or no longer relevant
Projects
SONAR issues
Status: Inbox
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmo @PascalRepond