Tree height and width are f32 but deserialised as Option<f32>

[lwiklendt]

Tree::height and Tree::width are f32 but are trying to be deserialised as Option<f32> resulting in an error

egui_tiles/src/tree.rs

Lines 57 to 62 in 3e7f324

	fn deserialize_f32_null_as_infinity<'de, D: serde::Deserializer<'de>>(
	des: D,
	) -> Result<f32, D::Error> {
	use serde::Deserialize;
	Ok(Option::<f32>::deserialize(des)?.unwrap_or(f32::INFINITY))
	}

[kgv]

relevant: emilk/egui#5176

[emilk]

I think we need to revert

• Fix Tree deserialization using JSON #85

[s-nie]

Either revert it or also handle the serialization the same way:

serde(serialize_with = "serialize_f32_infinity_as_null") for the fields and then:

#[cfg(feature = "serde")]
fn serialize_f32_infinity_as_null<S: serde::Serializer>(
    t: &f32,
    serializer: S,
) -> Result<S::Ok, S::Error> {
    if t.is_infinite() {
        serializer.serialize_none()
    } else {
        serializer.serialize_f32(*t)
    }
}

Edit based on @lwiklendt's suggestion:

#[cfg(feature = "serde")]
fn serialize_f32_as_infinity_as_null<S: serde::Serializer>(
    t: &f32,
    serializer: S,
) -> Result<S::Ok, S::Error> {
    if t.is_infinite() {
        serializer.serialize_none()
    } else {
        serializer.serialize_some(t)
    }
}

[lwiklendt]

handle the serialization the same way

The deserialiser is expecting an Option<f32>, so you would need to serialise it as an Option<f32>. That is, you would need to use something like serializer.serialize_option(t) instead of serializer.serialize_f32(*t). However, this would result in a surprising incoherence between the struct fields as f32 and their serialisation as Option<f32>.

[emilk]

Can JSON just add support for +/-inf already 🙄

[lwiklendt]

Wow, TIL JSON doesn't have inf and NaN support.
I'm using RON in my projects, so I was blissfully ignorant of the JSON problem.

[emilk]

• Closed by Fix Tree serialization #87