Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range query misses data when entity is logged with multiple log calls #1218

Open
Tracked by #1898
jleibs opened this issue Feb 11, 2023 · 1 comment
Open
Tracked by #1898
Labels
🏹 arrow concerning arrow 🪳 bug Something isn't working

Comments

@jleibs
Copy link
Member

jleibs commented Feb 11, 2023

See #1215 and #1217 for additional context.

If we are trying to log data about an entity and it ends up getting split over multiple log calls, it's important that we always log the non-primary component before the other data. If we don't, then the range-query will generate an entity missing this data for the start of the range.

Making a collection of log-calls calls "sync'd" in some way (sharing the exact timepoint) would be helpful for cases like this. Additionally we may need to add a bit of special casing in the join implementation.

It seems like any data with a timestamp that exactly matches the timestamp of the primary component should be included in the results, even if it arrived in a second call unless there is another primary component at that time timestamp, in which case 🤷‍♂️

@jleibs jleibs added 🪳 bug Something isn't working 🏹 arrow concerning arrow labels Feb 11, 2023
@emilk
Copy link
Member

emilk commented Feb 12, 2023

I think syncing the time points is the right solution here

The arrow store will still treat two log messages (even with identical time stamps) separably based on insertion order. You still end up with multiple rows in the store.

So if multiple rows have identical time stamps the initial range-result is just the first row.

…still, we should strive to have identical times when logging different components of the same entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow 🪳 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants