Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where capitalised type variables were only allowed in certa… #6820

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fix issue where capitalised type variables were only allowed in certa… #6820

merged 1 commit into from
Jun 19, 2024

Conversation

cristianoc
Copy link
Collaborator

…in positions.

Fixes #6759

@cristianoc cristianoc requested review from cknitt and zth June 19, 2024 06:45
zth
zth approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I honestly had no idea we allowed uppercase type variables at all..

cknitt
cknitt approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cristianoc cristianoc merged commit 70e25f7 into master Jun 19, 2024
19 checks passed
@cristianoc cristianoc deleted the uppercase_type_args branch June 19, 2024 16:24
@sminnee sminnee mentioned this pull request Aug 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uppercase type arguments don't work in inlined records
3 participants
@cristianoc @cknitt @zth