-
-
Notifications
You must be signed in to change notification settings - Fork 252
Make ES6 the default output for the playground #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
my impression was that ppl are still very heavily relying on commonjs (also for webpack setups etc)... i haven't been using any node that allowed ES6 imports so far (still relying on the Edit: According to the NodeJS docs, ES6 are still in
I wanted to hold off from local storage stuff after we collected some feedback for the new share-link feature. Local storage always means maintaining some kind of versioning schema to prevent problems with different bundle versions, also handle specific error scenarios, e.g. I can remember a time where the ReasonML playground couldn't boot up because I was loading malformed code from storage (ending in an endless loop). Definitely something to look into at some point |
Ok indeed experimental but it is enabled by default. I don't use node heavily but I did saw some projects pick up modules (eg Gatsby).
I would suggest each particular setting into a specific local storage key, so you don't need anything like that. I agree that keeping the code itself in local storage is potentially problematic (I experienced this with the reasonml playground multiple times as well). |
I revisited the state of ES6 modules, and you may be right, probably better to set to ES6 by default. Still not sure about local storage though (url parameters vs local storage etc) |
This was solved in #695 |
It's probably what 90% of the people would be using (isn't it the defacto standard for NodeJS as well at this point?).
Also it would be great to store the settings in localstorage, so they are restored on refresh
The text was updated successfully, but these errors were encountered: