Skip to content

Conversation

@fhammerschmidt
Copy link
Member

@fhammerschmidt fhammerschmidt commented Nov 14, 2023

Also removed a lot of final units in example code.

Copy link
Member

@ryyppy ryyppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments / nitpicks. But generally, looking great!

- `".bs.mjs"`
- `".bs.cjs"`

Currently prefer `.bs.js` for now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this... is this somewhat possible to fix? @cknitt @cristianoc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main concern was mostly about genType relying on bs.js when I am not mistaken? Nowadays genType reads the rescript.json anyways, so I assume some constraints regarding configuring the .js extension should be lifted?

Copy link
Member

@ryyppy ryyppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only question I have is how we treat the (.) => {} syntax in the docs.

As I understand, everything is now an uncurried function. But at some point ppl will see the syntax and wonder what it is.

@fhammerschmidt fhammerschmidt merged commit 4d7cc30 into rescript-11 Nov 15, 2023
@fhammerschmidt fhammerschmidt deleted the uncurried-docs branch November 15, 2023 22:09
@fhammerschmidt
Copy link
Member Author

Suggestion:

fhammerschmidt added a commit to fhammerschmidt/rescript-lang.org that referenced this pull request Dec 5, 2023
fhammerschmidt added a commit to fhammerschmidt/rescript-lang.org that referenced this pull request Dec 5, 2023
fhammerschmidt added a commit to fhammerschmidt/rescript-lang.org that referenced this pull request Dec 27, 2023
fhammerschmidt added a commit to fhammerschmidt/rescript-lang.org that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants