-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The module or file RescriptCore can't be found. #1056
Comments
Hello, could you share your |
Sorry, I forgot. Here: {
"name": "rescript-project-template",
"sources": {
"dir": "src",
"subdirs": true
},
"package-specs": {
"module": "commonjs",
"in-source": true
},
"suffix": ".res.js",
"bs-dependencies": ["@rescript/core"],
"bsc-flags": ["-open RescriptCore"]
} Everything was generated automatically through create-rescript-app, and I didn't make any changes. |
Ok, just wanted to check if you were not missing the entry in Did |
In your case probably |
I'm sure I've executed |
I just created a create-rescript-app basic project with pnpm and do not have this issue. I hope it's not windows-specific. I guess you also tried to restart the language server from VSCode's command palette? Other than that what does the OUTPUT tab say when you select "ReScript Language Server" from the dropdown menu? |
No further information beyond this: And my system version is |
I can reproduce the error in your output if I do But as soon as I do Everything works again. And to me it really just looks like the LSP got stuck and needs a restart. Btw. when you close all rescript tabs and open one again, it also gets restarted. |
I've tried to clean rescript and restart VSC, but it has no effect. After I closed Now I need to run |
That's curious, maybe there is a Windows bug in path handling of incremental compilation. @zth When incremental typechecking is off, it should still typecheck/compile after every save. Personally, I always have a watcher running in a separate terminal as this one can not get killed by the VSCode extension. The LSP relies on a successful compile to gather type information, if you have an error in your code it might not be able to give you accurate type information. |
There might very well be some issue with windows and path handling for incremental typechecking, yes. |
Not so fast, GitHub. @BIYUEHU can you try setting your extension to the pre-release version 1.59.6 and see if incremental compilation works there? |
I tried.Type checking is working normally: But the first problem still exists: |
Report details:
v1.58.0
create-rescript-app
and already installed all packages.E:\repos\my-res
Part of
Package.json
:Visual Studio Code
information:Screenboot:
The text was updated successfully, but these errors were encountered: