Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition return invalid Range #779

Closed
aspeddro opened this issue May 26, 2023 · 0 comments · Fixed by #781
Closed

Definition return invalid Range #779

aspeddro opened this issue May 26, 2023 · 0 comments · Fixed by #781

Comments

@aspeddro
Copy link
Contributor

https://github.com/rescript-association/rescript-lang.org/blob/aae97c5029e8c304a2ddba7eac5bd234f7a08217/src/Playground.res#LL1386C14-L1386C14

Res constructor, col 13

dune exec -- rescript-editor-analysis definition ~/Desktop/projects/rescript-lang.org/src/Playground.res 1385 13

{"uri": "file:///home/pedro/Desktop/projects/rescript-lang.org/src/bindings/RescriptCompilerApi.resi", "range": {"start": {"line": 0, "character": -1}, "end": {"line": 0, "character": -1}}}

The typeDefinition command return the correct range.

dune exec -- rescript-editor-analysis typeDefinition ~/Desktop/projects/rescript-lang.org/src/Playground.res 1385 13

{"uri": "file:///home/pedro/Desktop/projects/rescript-lang.org/src/bindings/RescriptCompilerApi.resi", "range": {"start": {"line": 9, "character": 2}, "end": {"line": 12, "character": 9}}}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid range aspeddro/rescript-vscode
1 participant
@aspeddro