fix reserved words (#6831)

* fix reserved words

* allow more names that isn't related to CommonJS

* add changelog

* remove codegen script completely

* use Hashtbl instead of Set

Author: cometkim

CHANGELOG.md

@@ -26,6 +26,7 @@
 - Remove obsolete `@bs.open` feature. https://github.com/rescript-lang/rescript-compiler/pull/6629
 - Drop Node.js version <18 support, due to it reaching End-of-Life. https://github.com/rescript-lang/rescript-compiler/pull/6429
 - Remove deprecated -bs-super-errors option. https://github.com/rescript-lang/rescript-compiler/pull/6814
+- Some global names and old keywords are no longer prefixed. https://github.com/rescript-lang/rescript-compiler/pull/6831
 
 #### :bug: Bug Fix
 

CONTRIBUTING.md

@@ -300,17 +300,6 @@ To generate the html:
 ../scripts/ninja docs
 ```
 
-## Update JS Reserved Keywords Map
-
-The compiler sources include a list of reserved JS keywords in `jscomp/ext/js_reserved_map.ml` which includes all identifiers in global scope (`window`). This list should be updated from time to time for newer browser versions.
-
-To update it, run:
-
-```sh
-npm install puppeteer
-node scripts/build_reserved.js
-```
-
 ## Code structure
 
 The highlevel architecture is illustrated as below:

jscomp/ext/ext_ident.ml

@@ -23,12 +23,6 @@
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
 
 
-
-
-
-
-
-
 let js_flag = 0b1_000 (* check with ocaml compiler *)
 
 (* let js_module_flag = 0b10_000 (\* javascript external modules *\) *)
@@ -172,18 +166,14 @@ let name_mangle name =
         Ext_buffer.add_string buffer (convert ~op:(i=0) c)        
     done; Ext_buffer.contents buffer
 
-(* TODO:
-    check name conflicts with javascript conventions
-   {[
-     Ext_ident.convert "^";;
-     - : string = "$caret"
-   ]}
-   [convert name] if [name] is a js keyword,add "$$"
+(**
+   [convert name] if [name] is a js keyword or js global, add "$$"
    otherwise do the name mangling to make sure ocaml identifier it is
    a valid js identifier
 *)
 let convert (name : string) =
-  if  Js_reserved_map.is_reserved name  then
+  let name = unwrap_uppercase_exotic name in
+  if Js_reserved_map.is_js_keyword name || Js_reserved_map.is_js_global name then
     "$$" ^ name
   else name_mangle name