Merge branch 'master' into moar-rewatch-tests

Author: nojaf

.github/workflows/ci.yml

@@ -674,6 +674,8 @@ jobs:
         shell: bash
 
   publish:
+    permissions:
+      id-token: write
     needs:
       - test-installation-npm
       - test-installation-pnpm
@@ -701,11 +703,9 @@ jobs:
         shell: bash
 
       - name: Publish packages on npm with tag "ci"
-        env:
-          YARN_NPM_AUTH_TOKEN: ${{ secrets.NPM_ACCESS_TOKEN }}
         run: |
           yarn workspaces foreach -W --no-private \
-            npm publish --tolerate-republish --tag ci
+            npm publish --provenance --tolerate-republish --tag ci
 
       - name: Update Website Playground
         run: curl -X POST "${{ secrets.CLOUDFLARE_PAGES_DEPLOYMENT_HOOK }}"

CHANGELOG.md

@@ -14,20 +14,33 @@
 
 #### :boom: Breaking Change
 
+- Fix return type of `String.charCodeAt`. https://github.com/rescript-lang/rescript/pull/7864
+- Remove support of JSX children spread. https://github.com/rescript-lang/rescript/pull/7869
+
 #### :eyeglasses: Spec Compliance
 
 #### :rocket: New Feature
 
+- Add `Array.filterMapWithIndex` to Stdlib. https://github.com/rescript-lang/rescript/pull/7876
+
 #### :bug: Bug fix
 
 - Fix code generation for emojis in polyvars and labels. https://github.com/rescript-lang/rescript/pull/7853
+- Add `reset` to `experimental_features` to correctly reset playground. https://github.com/rescript-lang/rescript/pull/7868
+- Fix crash with `@get` on external of type `unit => 'a`. https://github.com/rescript-lang/rescript/pull/7866
+- Fix record type spreads in inline records. https://github.com/rescript-lang/rescript/pull/7859
 
 #### :memo: Documentation
 
 #### :nail_care: Polish
 
+- Reactivate optimization for length of array literals. https://github.com/rescript-lang/rescript/pull/7872
+- `Float.isNaN`: use `Number.isNaN` instead of global `isNaN`. https://github.com/rescript-lang/rescript/pull/7874
+
 #### :house: Internal
 
+- Playground: Add config options for experimental features and jsx preserve mode. https://github.com/rescript-lang/rescript/pull/7865
+- Clean up tests. https://github.com/rescript-lang/rescript/pull/7861 https://github.com/rescript-lang/rescript/pull/7871
 - Add `-runtime-path` flag to `bsc` (and `bsb`), we are detecting the location of `@rescript/runtime` in `cli/rescript.js` based on runtime module resolution. https://github.com/rescript-lang/rescript/pull/7858
 
 # 12.0.0-beta.10

CONTRIBUTING.md

@@ -227,14 +227,23 @@ Below we will discuss on how to write, build and run these test files.
 - Inside the file, add a mocha test suite. The mocha bindings are defined in `tests/tests/src/mt.res`. To get you started, here is a simple scaffold for a test suite with multiple test cases:
 
   ```rescript
-  let suites: Mt.pair_suites = list{
-    ("hey", _ => Eq(true, 3 > 2)),
-    ("hi", _ => Neq(2, 3)),
-    ("hello", _ => Approx(3.0, 3.0)),
-    ("throw", _ => ThrowAny(_ => raise(SomeException))),
-  }
-
-  Mt.from_pair_suites(__MODULE__, suites)
+  open Mocha
+  open Test_utils
+
+  describe(__MODULE__, () => {
+    test("hey", () => {
+      ok(__LOC__, 3 > 2)
+    })
+
+    test("hi", () => {
+      eq(__LOC__, 2, 2)
+      eq(__LOC__, 3, 3)
+    })
+
+    test("throw", () => {
+      throws(__LOC__, () => throw(SomeException))
+    })
+  })
   ```
 
 - Build the test files and run the tests: `node scripts/test.js -mocha`.

analysis/src/CompletionFrontEnd.ml

@@ -1353,7 +1353,7 @@ let completionWithParser1 ~currentFile ~debug ~offset ~path ~posCursor
                 (Jsx_container_element
                    {jsx_container_element_children = children}) ->
               children
-            | _ -> JSXChildrenItems []
+            | _ -> []
           in
           let compName_loc = compName.loc in
           let compName_lid =
@@ -1412,8 +1412,7 @@ let completionWithParser1 ~currentFile ~debug ~offset ~path ~posCursor
                   (Jsx_container_element
                      {
                        jsx_container_element_closing_tag = None;
-                       jsx_container_element_children =
-                         JSXChildrenSpreading _ | JSXChildrenItems (_ :: _);
+                       jsx_container_element_children = _ :: _;
                      }) ) ->
               None
             | Some jsxProps, _ ->

analysis/src/CompletionJsx.ml

@@ -460,8 +460,8 @@ let extractJsxProps ~(compName : Longident.t Location.loc) ~props ~children =
   let open Parsetree in
   let childrenStart =
     match children with
-    | JSXChildrenItems [] -> None
-    | JSXChildrenSpreading child | JSXChildrenItems (child :: _) ->
+    | [] -> None
+    | child :: _ ->
       if child.pexp_loc.loc_ghost then None else Some (Loc.start child.pexp_loc)
   in
   let props =

analysis/src/SemanticTokens.ml

@@ -311,10 +311,7 @@ let command ~debug ~emitter ~path =
            ~pos:(Pos.ofLexing posOfGreatherthanAfterProps);
 
       (* children *)
-      (match children with
-      | Parsetree.JSXChildrenSpreading child -> iterator.expr iterator child
-      | Parsetree.JSXChildrenItems children ->
-        List.iter (iterator.expr iterator) children);
+      List.iter (iterator.expr iterator) children;
 
       (* closing tag *)
       closing_tag_opt

biome.json

@@ -65,6 +65,7 @@
       "rewatch/**",
       "lib/es6/**",
       "lib/js/**",
+      "lib/bs/**",
       "ninja/**",
       "playground/**",
       "*.bs.js",

compiler/core/lam_compile_external_call.ml

@@ -421,7 +421,11 @@ let translate_ffi ?(transformed_jsx = false) (cxt : Lam_compile_context.t)
     | [obj] ->
       let obj = translate_scoped_access scopes obj in
       E.dot obj name
-    | _ -> assert false
+    | _ ->
+      (* This should have been caught in the frontend validation. *)
+      invalid_arg
+        "Internal compiler error: @get external called with wrong number of \
+         arguments. Expected exactly one object argument."
     (* Note these assertion happens in call site *))
   | Js_set {js_set_name = name; js_set_scopes = scopes} -> (
     (* assert (js_splice = false) ;  *)

compiler/frontend/ast_external_process.ml

@@ -899,7 +899,12 @@ let external_desc_of_non_obj (loc : Location.t) (st : external_desc)
    tagged_template = _;
   } ->
     if arg_type_specs_length = 1 then
-      Js_get {js_get_name = name; js_get_scopes = scopes}
+      (* Check if the first argument is unit, which is invalid for @get *)
+      match arg_type_specs with
+      | [{arg_type = Extern_unit}] ->
+        Location.raise_errorf ~loc
+          "Ill defined attribute %@get (unit argument is not allowed)"
+      | _ -> Js_get {js_get_name = name; js_get_scopes = scopes}
     else
       Location.raise_errorf ~loc
         "Ill defined attribute %@get (only one argument)"

compiler/frontend/bs_ast_mapper.ml

@@ -292,9 +292,7 @@ module M = struct
 end
 
 module E = struct
-  let map_jsx_children sub = function
-    | JSXChildrenSpreading e -> JSXChildrenSpreading (sub.expr sub e)
-    | JSXChildrenItems xs -> JSXChildrenItems (List.map (sub.expr sub) xs)
+  let map_jsx_children sub xs = List.map (sub.expr sub) xs
 
   let map_jsx_prop sub = function
     | JSXPropPunning (optional, name) ->