Merge branch '11.0_release' into fix/recover-broken-jsx-prop

Author: shulhi

.github/workflows/ci.yml

@@ -33,29 +33,22 @@ jobs:
 
     runs-on: ${{matrix.os}}
 
-    container:
-      image: ghcr.io/rescript-lang/rescript-ci-build:alpine-3.19-ocaml-4.14.1-02
-
     steps:
-      # See https://github.com/actions/runner/issues/801#issuecomment-1374967227.
-      - name: Workaround for Github actions runner on Alpine arm64
-        if: runner.arch	== 'ARM64'
-        run: sed -i "s:ID=alpine:ID=NotpineForGHA:" /etc/os-release
-
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Build compiler binaries
-        run: opam exec -- dune build --display quiet --profile static
+        uses: docker://ghcr.io/rescript-lang/rescript-ci-build:alpine-3.19-ocaml-4.14.1-02
+        with:
+          args: opam exec -- dune build --display quiet --profile static
 
       - name: Build ninja binary
-        working-directory: ninja
-        env:
-          LDFLAGS: -static
-        run: python3 configure.py --bootstrap --verbose
+        uses: docker://ghcr.io/rescript-lang/rescript-ci-build:alpine-3.19-ocaml-4.14.1-02
+        with:
+          args: sh -c "cd ninja && LDFLAGS=-static python3 configure.py --bootstrap"
 
       - name: "Upload artifacts"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: static-binaries-linux-${{runner.arch}}
           path: |
@@ -72,11 +65,11 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Download static linux binaries
         if: runner.os == 'Linux'
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: static-binaries-linux-${{ runner.arch }}
 
@@ -87,7 +80,7 @@ jobs:
           chmod +x _build/install/default/bin/*
 
       - name: Use Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 16
 
@@ -98,7 +91,7 @@ jobs:
         run: node .github/workflows/get_artifact_info.js
 
       - name: "Upload artifacts: binaries"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ env.artifact_name }}
           path: ${{ env.artifact_path }}
@@ -130,13 +123,13 @@ jobs:
           git config --global core.eol lf
 
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 2 # to be able to check for changes in subfolder jscomp/syntax later
 
       - name: Download static linux binaries
         if: runner.os == 'Linux'
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: static-binaries-linux-${{ runner.arch }}
 
@@ -173,7 +166,7 @@ jobs:
         run: opam exec -- dune build --display quiet --profile release
 
       - name: Use Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 16
 
@@ -182,7 +175,7 @@ jobs:
 
       - name: "Windows: Use MSVC for ninja build"
         if: runner.os == 'Windows'
-        uses: TheMrMilchmann/setup-msvc-dev@v2
+        uses: TheMrMilchmann/setup-msvc-dev@v3
         with:
           arch: x64
 
@@ -262,14 +255,14 @@ jobs:
         run: node .github/workflows/get_artifact_info.js
 
       - name: "Upload artifacts: binaries"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ env.artifact_name }}
           path: ${{ env.artifact_path }}
 
       - name: "Upload artifacts: lib/ocaml"
         if: runner.os == 'Linux'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: lib-ocaml
           path: lib/ocaml
@@ -280,18 +273,18 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Use Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 16
 
       - name: NPM install
         run: npm ci --ignore-scripts
 
       - name: Download artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
 
       - name: Move artifacts
         run: ./scripts/moveArtifacts.sh
@@ -314,7 +307,7 @@ jobs:
         run: node .github/workflows/prepare_package_upload.js ${{ github.event.pull_request.head.sha }}
 
       - name: "Upload artifact: npm packages"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: npm-packages
           path: |
@@ -341,15 +334,15 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Use Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 16
 
       - name: Download artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: npm-packages
           path: packages/test
@@ -373,16 +366,16 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Use Node.js
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 16
           registry-url: https://registry.npmjs.org # Needed to make auth work for publishing
 
       - name: Download artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: npm-packages
 

CHANGELOG.md

@@ -10,7 +10,21 @@
 > - :house: [Internal]
 > - :nail_care: [Polish]
 
-# 11.1.0-rc.3 (Unreleased)
+# 11.1.0-rc.4 (Unreleased)
+
+#### :nail-care: Polish
+- Omit `undefined` in external function calls for trailing optional arguments when not supplied. https://github.com/rescript-lang/rescript-compiler/pull/6653
+
+# 11.1.0-rc.3
+
+#### :nail_care: Polish
+
+- No parens around tagged template literals. https://github.com/rescript-lang/rescript-compiler/pull/6639
+- Allow identifier with modules in tagged template literals (e.g. Pg.sql`select * from ${table} where id = ${id}`). https://github.com/rescript-lang/rescript-compiler/pull/6645
+
+#### :bug: Bug Fix
+
+- Fix compiler crash when reexporting tagged template literal externals. https://github.com/rescript-lang/rescript-compiler/pull/6645
 
 # 11.1.0-rc.2
 

jscomp/common/bs_version.ml

@@ -21,6 +21,6 @@
  * You should have received a copy of the GNU Lesser General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)
-let version = "11.1.0-rc.3"
+let version = "11.1.0-rc.4"
 let header = "// Generated by ReScript, PLEASE EDIT WITH CARE"
 let package_name = ref "rescript"

jscomp/core/lam_compile_external_call.ml

@@ -252,16 +252,15 @@ let translate_scoped_access scopes obj =
 let translate_ffi (cxt : Lam_compile_context.t) arg_types
     (ffi : External_ffi_types.external_spec) (args : J.expression list) =
   match ffi with
-  | Js_call { external_module_name; name; splice; scopes; tagged_template = true } -> 
+  | Js_call { external_module_name; name; splice: _; scopes; tagged_template = true } -> 
       let fn = translate_scoped_module_val external_module_name name scopes in 
       (match args with
-      | [ stringArgs; valueArgs ] -> (
-          match (stringArgs, valueArgs) with
-          | ({expression_desc = Array (strings, _); _}, {expression_desc = Array (values, _); _}) ->
-              E.tagged_template fn strings values
-          | _ -> assert false
-          )
-      | _ -> assert false)
+      | [ {expression_desc = Array (strings, _); _}; {expression_desc = Array (values, _); _} ] -> 
+        E.tagged_template fn strings values
+      | _ -> let args, eff, dynamic = assemble_args_has_splice arg_types args in
+        add_eff eff
+          (if dynamic then splice_apply fn args
+          else E.call ~info:{ arity = Full; call_info = Call_na } fn args))
   | Js_call { external_module_name = module_name; name = fn; splice; scopes; tagged_template = false } ->
       let fn = translate_scoped_module_val module_name fn scopes in
       if splice then
@@ -271,6 +270,16 @@ let translate_ffi (cxt : Lam_compile_context.t) arg_types
           else E.call ~info:{ arity = Full; call_info = Call_na } fn args)
       else
         let args, eff = assemble_args_no_splice arg_types args in
+        let rec keepNonUndefinedArgs argsList (argTypes : specs) =
+          match (argsList, argTypes) with
+          | ( {J.expression_desc = Undefined {isUnit = false}; _} :: rest,
+              {External_arg_spec.arg_label = Arg_optional; _} :: argTypes ) ->
+            keepNonUndefinedArgs rest argTypes
+          | _ -> argsList
+        in
+        let args =
+          keepNonUndefinedArgs (List.rev args) (List.rev arg_types) |> List.rev
+        in
         add_eff eff
         @@ E.call ~info:{ arity = Full; call_info = Call_na } fn args
   | Js_module_as_fn { external_module_name; splice } ->

jscomp/syntax/src/res_core.ml

@@ -2140,8 +2140,7 @@ and parsePrimaryExpr ~operand ?(noCall = false) p =
     | Backtick
       when noCall = false && p.prevEndPos.pos_lnum == p.startPos.pos_lnum -> (
       match expr.pexp_desc with
-      | Pexp_ident {txt = Longident.Lident ident} ->
-        parseTemplateExpr ~prefix:ident p
+      | Pexp_ident long_ident -> parseTemplateExpr ~prefix:long_ident p
       | _ ->
         Parser.err ~startPos:expr.pexp_loc.loc_start
           ~endPos:expr.pexp_loc.loc_end p
@@ -2322,13 +2321,15 @@ and parseBinaryExpr ?(context = OrdinaryExpr) ?a p prec =
 (* | _ -> false *)
 (* ) *)
 
-and parseTemplateExpr ?(prefix = "js") p =
+and parseTemplateExpr ?prefix p =
   let partPrefix =
     (* we could stop treating js and j prefix as something special
        for json, we would first need to remove @as(json`true`) feature *)
     match prefix with
-    | "js" | "j" | "json" -> Some prefix
-    | _ -> None
+    | Some {txt = Longident.Lident (("js" | "j" | "json") as prefix); _} ->
+      Some prefix
+    | Some _ -> None
+    | None -> Some "js"
   in
   let startPos = p.Parser.startPos in
 
@@ -2365,8 +2366,7 @@ and parseTemplateExpr ?(prefix = "js") p =
   let values = Ext_list.filter_map parts snd in
   let endPos = p.Parser.endPos in
 
-  let genTaggedTemplateCall () =
-    let lident = Longident.Lident prefix in
+  let genTaggedTemplateCall lident =
     let ident =
       Ast_helper.Exp.ident ~attrs:[] ~loc:Location.none
         (Location.mknoloc lident)
@@ -2417,8 +2417,9 @@ and parseTemplateExpr ?(prefix = "js") p =
   in
 
   match prefix with
-  | "js" | "j" | "json" -> genInterpolatedString ()
-  | _ -> genTaggedTemplateCall ()
+  | Some {txt = Longident.Lident ("js" | "j" | "json"); _} | None ->
+    genInterpolatedString ()
+  | Some {txt = lident} -> genTaggedTemplateCall lident
 
 (* Overparse: let f = a : int => a + 1, is it (a : int) => or (a): int =>
  * Also overparse constraints:

jscomp/syntax/tests/printer/other/expected/string.res.txt

@@ -17,3 +17,5 @@ let heart = "\u2665"
 let smile = "emoji: \u{1F600}"
 
 let taggedTemplate = sql`select * from ${table} where id = ${id}`
+
+let taggedTemplate = Pg.sql`select * from ${table} where id = ${id}`

jscomp/syntax/tests/printer/other/string.res

@@ -16,4 +16,6 @@ let heart = "\u2665"
 
 let smile = "emoji: \u{1F600}"
 
-let taggedTemplate = sql`select * from ${table} where id = ${id}`
+let taggedTemplate = sql`select * from ${table} where id = ${id}`
+
+let taggedTemplate = Pg.sql`select * from ${table} where id = ${id}`

jscomp/test/build.ninja

@@ -0,0 +1,11 @@
+@@uncurried
+
+type dateFormatOptions = {someOption?: bool}
+
+@module("SomeModule")
+external formatDate: (Js.Date.t, ~options: dateFormatOptions=?, ~done: bool=?) => string =
+  "formatDate"
+
+let x = formatDate(Js.Date.make())
+let x = formatDate(Js.Date.make(), ~options={someOption: true})
+let x = formatDate(Js.Date.make(), ~done=true)