Reuse original env when instantiating type (#7231)

* Reuse original env when instantiating type

* Clean up code comment

* Okay, somethings did change

* After building local compiler

* Fix doc thing?

* Add changelog entry

Author: nojaf

CHANGELOG.md

@@ -12,6 +12,10 @@
 
 # 12.0.0-alpha.8 (Unreleased)
 
+#### :bug: Bug fix
+
+- Editor: Fix issue where pipe completions would not trigger with generic type arguments. https://github.com/rescript-lang/rescript/pull/7231
+
 # 12.0.0-alpha.7
 
 #### :bug: Bug fix

CONTRIBUTING.md

@@ -119,7 +119,19 @@ After adding a new file to the repository that should go into the npm package -
 
 ```sh
 make lib # Build compiler and standard library
-./bsc myTestFile.res
+./cli/bsc myTestFile.res
+```
+
+To view the untyped tree of the file run:
+
+```sh
+./cli/bsc -dparsetree myTestFile.res
+```
+
+To view the typed tree of the file run:
+
+```sh
+./cli/bsc -dtypedtree myTestFile.res
 ```
 
 ### Project

analysis/README.md

@@ -16,6 +16,12 @@ See main CONTRIBUTING.md's repo structure. Additionally, `examples/` is a conven
 dune exec -- rescript-editor-analysis --help
 ```
 
+Add verbose logging via:
+
+```shell
+dune exec -- rescript-editor-analysis debug-dump verbose test
+```
+
 ## History
 
 This project is based on a fork of [Reason Language Server](https://github.com/jaredly/reason-language-server).

analysis/src/TypeUtils.ml

@@ -270,7 +270,7 @@ let extractFunctionTypeWithEnv ~env ~package typ =
     | Tconstr (path, typeArgs, _) -> (
       match References.digConstructor ~env ~package path with
       | Some
-          ( env,
+          ( _env,
             {
               item = {decl = {type_manifest = Some t1; type_params = typeParams}};
             } ) ->

tests/analysis_tests/tests/package-lock.json

@@ -0,0 +1,33 @@
+module Firebase = {
+  module Firestore = {
+    type firestore
+
+    type documentReference<'documentdata> = {
+      id: string,
+      path: string,
+    }
+
+    type documentSnapshot<'documentdata> = {
+      id: string,
+      ref: documentReference<'documentdata>,
+    }
+
+    @module("firebase/firestore") @variadic
+    external doc: (firestore, string, array<string>) => documentReference<'documentdata> = "doc"
+
+    @module("firebase/firestore")
+    external getDoc: documentReference<'documentdata> => Promise.t<
+      documentSnapshot<'documentdata>,
+    > = "getDoc"
+  }
+}
+
+module Sample = {
+  open Firebase
+
+  external store: Firestore.firestore = "store"
+
+  let ref = store->Firestore.doc("some_id", [])
+  // ref.
+  //     ^com
+}

tests/analysis_tests/tests/src/Firebase.res

@@ -0,0 +1,41 @@
+Complete src/Firebase.res 30:9
+posCursor:[30:9] posNoWhite:[30:8] Found expr:[30:5->30:9]
+Pexp_field [30:5->30:8] _:[32:0->30:9]
+Completable: Cpath Value[ref].""
+Raw opens: 1 Firebase.place holder
+Package opens Pervasives.JsxModules.place holder
+Resolved opens 1 Firebase
+ContextPath Value[ref].""
+ContextPath Value[ref]
+Path ref
+ContextPath Value[ref]->
+ContextPath Value[ref]
+Path ref
+CPPipe pathFromEnv:Firebase.Firestore found:true
+Path Firebase.Firestore.
+[{
+    "label": "id",
+    "kind": 5,
+    "tags": [],
+    "detail": "string",
+    "documentation": {"kind": "markdown", "value": "```rescript\nid: string\n```\n\n```rescript\ntype documentReference<'documentdata> = {\n  id: string,\n  path: string,\n}\n```"}
+  }, {
+    "label": "path",
+    "kind": 5,
+    "tags": [],
+    "detail": "string",
+    "documentation": {"kind": "markdown", "value": "```rescript\npath: string\n```\n\n```rescript\ntype documentReference<'documentdata> = {\n  id: string,\n  path: string,\n}\n```"}
+  }, {
+    "label": "->Firestore.getDoc",
+    "kind": 12,
+    "tags": [],
+    "detail": "documentReference<\n  'documentdata,\n> => Promise.t<documentSnapshot<'documentdata>>",
+    "documentation": null,
+    "sortText": "getDoc",
+    "insertText": "->Firestore.getDoc",
+    "additionalTextEdits": [{
+      "range": {"start": {"line": 30, "character": 8}, "end": {"line": 30, "character": 9}},
+      "newText": ""
+      }]
+  }]
+