Skip to content

RFC: Bitwise module in belt #5176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amiralies opened this issue Jun 12, 2021 · 4 comments
Closed

RFC: Bitwise module in belt #5176

amiralies opened this issue Jun 12, 2021 · 4 comments

Comments

@amiralies
Copy link
Contributor

The old operators inherited from ocaml are less accessible and somehow hidden from user and the names are not descriptive IMO.
Should we have a lightweight Belt.Bitwise ?
@bobzhang
Copy link
Member

Bit wise operations mostly operate on int, shall we add it inside Belt.Int?

@amiralies
Copy link
Contributor Author

That's also a good place. do you think it should be better to put them inside a submodule (Belt.Int.Bitwise) or alongside other functions in Belt.Int ?

@bobzhang
Copy link
Member

I would like to have a flat structure: it is good for future docs generation, nested submodules have perf cost

@bobzhang
Copy link
Member

Hi, adding bitwise operations into Belt.Int is welcome. We also welcome to move some float operations in Pervasives into Belt.Float

@soanvig soanvig mentioned this issue Sep 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobzhang @amiralies