Skip to content

Remove the unnecessary binaries after install #5389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
mununki opened this issue May 23, 2022 · 3 comments
Closed
5 tasks done

Remove the unnecessary binaries after install #5389

mununki opened this issue May 23, 2022 · 3 comments
Labels
stale Old issues that went stale

Comments

@mununki
Copy link
Member

mununki commented May 23, 2022

Thank you for filing! Check list:

  • Is it a bug? Usage questions should often be asked in the forum instead.
  • Concise, focused, friendly issue title & description.
  • A minimal, reproducible example.
  • OS and browser versions, if relevant.
  • Is it already fixed in master?
  • OS: macOS (M1)

There are unnecessary binaries after installation in node_modules directory. AFIK, most ppx packages which are shipped by npm are using postinstall script to remove the unnecessary binaries after installation. Isn't it preferable to remove it for users? If you want me to add the postinstall script, I'll contribute it.

image

@mununki mununki changed the title Remove the unnecessary binary after install Remove the unnecessary binaries after install May 23, 2022
@cknitt
Copy link
Member

cknitt commented May 27, 2023

@mununki This would be superseded by #6183.

@cometkim
Copy link
Member

Relying on postinstall scripts is not a good idea. Either for read/write. npm config set ignore-scripts true is a recommended setting for security reasons.

https://medium.com/cider-sec/npm-might-be-executing-malicious-code-in-your-ci-without-your-knowledge-e5e45bab2fed

Copy link

github-actions bot commented Dec 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Old issues that went stale label Dec 9, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Old issues that went stale
Projects
None yet
Development

No branches or pull requests

3 participants