Skip to content

Update React modules in jscomp/test #5438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mununki opened this issue Jun 15, 2022 · 2 comments
Closed

Update React modules in jscomp/test #5438

mununki opened this issue Jun 15, 2022 · 2 comments
Milestone

Comments

@mununki
Copy link
Member

mununki commented Jun 15, 2022

AFAIK, there are react related modules in ReasonML for easy testing, I guess. It seems outdated and causes the build to fail for ppx v4 which annotates the ref type to ReactDOM https://github.com/rescript-lang/syntax/blob/0bbb5f8e30f220c5d6fe7b836d663a7272cbedff/cli/reactjs_jsx_ppx_v3.ml#L41.

Should it be updated or re-allocated?

@cristianoc
Copy link
Collaborator

This is a good question -- when to break compatibility with old reason react.
Even though not necessary for 10.0, if a PPX V4 would go in 10.1, it makes sense to break already from 10.0 as a preparation step.

I guess this needs to be spelled out in #5413
So that a breaking notice goes out with the compiler release.

@cristianoc
Copy link
Collaborator

Also again, worth asking in the forum that there are no unintended consequences.

@cristianoc cristianoc modified the milestones: v10.0, v10.1 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants