Skip to content

Deprecate js_cast.ml? #5439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ryyppy opened this issue Jun 16, 2022 · 1 comment · Fixed by #7075
Closed

Deprecate js_cast.ml? #5439

ryyppy opened this issue Jun 16, 2022 · 1 comment · Fixed by #7075
Assignees
@ryyppy
Milestone
v12

Comments

@ryyppy
Copy link
Member

ryyppy commented Jun 16, 2022

jscomp/others/js_cast.ml seems to be obsolete. It offers conversion functions from int to bool and vice versa; probably from a time where booleans where not zero-cost.
@ryyppy ryyppy self-assigned this Jun 22, 2022
@cknitt cknitt added this to the v12 milestone Aug 25, 2024
@cknitt
Copy link
Member

cknitt commented Aug 25, 2024

Wasn't even aware this exists. I think it can be removed in v12.

@cknitt cknitt mentioned this issue Sep 1, 2024
Open
7 tasks
This was referenced Oct 4, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryyppy ryyppy

Labels
None yet
Projects
None yet
Milestone
v12
2 participants
@cknitt @ryyppy