Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template literals: Missing compiler error location #6655

Closed
DZakh opened this issue Feb 27, 2024 · 3 comments
Closed

Template literals: Missing compiler error location #6655

DZakh opened this issue Feb 27, 2024 · 3 comments

Comments

@DZakh
Copy link
Contributor

DZakh commented Feb 27, 2024

Version: rescript 11.1.0-rc.3

The non-existed function is not highlighted and there's no location in the compilation error as well.

image
@zth
Copy link
Collaborator

zth commented Feb 27, 2024

@tsnobip probably sdf is a ghost loc.

@tsnobip
Copy link
Contributor

tsnobip commented Feb 27, 2024

Version: rescript 11.1.0-rc.3

The non-existed function is not highlighted and there's no location in the compilation error as well.

Hmm yes error location is pretty bad right now, it's the last piece remaining for this feature, I have to make it right for IDE support too. It was my first significant contribution to the syntax, I'm still learning ^^

@cknitt
Copy link
Member

cknitt commented Sep 1, 2024

Fixed in #6816.

@cknitt cknitt closed this as completed Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants