Fix regex literal loc #7683
Merged
Fix regex literal loc #7683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
force-pushed
the
fix-regex-syntax-loc
branch
from
b21f017 to
3dbbb44
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
shulhi
reviewed
Jul 20, 2025
compiler/syntax/src/res_core.ml
Outdated
Comment on lines
1818
to
1826
| let loc = | ||
| mk_loc | ||
| { | ||
| start_pos with | ||
| (* Account for the inserted leading `/` *) | ||
| pos_cnum = start_pos.pos_cnum - 1; | ||
| } | ||
| p.prev_end_pos | ||
| in |
There was a problem hiding this comment.
Would it work if you pass in the start_pos from the caller function in here?
rescript/compiler/syntax/src/res_core.ml
Line 1836 in 249cb40
There was a problem hiding this comment.
Probably! I'll try it when I'm back at the computer.
There was a problem hiding this comment.
@shulhi yup, much better. Thank you!
zth
force-pushed
the
fix-regex-syntax-loc
branch
from
172bff5 to
1cb5bf3
Compare
zth
force-pushed
the
fix-regex-syntax-loc
branch
from
1cb5bf3 to
ee43d01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the regex literal locations, so error messages work properly.
No idea if this is the correct fix though. Maybe @shulhi or @cristianoc has opinions?
Closes #7682