Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom JSX module #130

Closed
dkirchhof opened this issue Jul 17, 2024 · 9 comments
Closed

Custom JSX module #130

dkirchhof opened this issue Jul 17, 2024 · 9 comments

Comments

@dkirchhof
Copy link

dkirchhof commented Jul 17, 2024

Hey,
I want to use rewatch in a project with a custom jsx module. But it isn't allowed.
The parser throws an error like: unknown variant MyCustomJSX, expected react at line 25 column 24".

Cheers
Daniel

@zth
Copy link
Contributor

zth commented Sep 15, 2024

Sounds like this should just be a matter of adapting Rewatch to use the same rules for that config as bsb currently does.

@dkirchhof
Copy link
Author

🙏

@rolandpeelen
Copy link
Member

Assuming this is fixed @dkirchhof -- Feel free to reopen though :)

@dkirchhof
Copy link
Author

dkirchhof commented Oct 22, 2024

No, the error still exists. Can't see any changes in the commits since I opened the issue.
Can't reopen the issue.

@rolandpeelen
Copy link
Member

@dkirchhof -- Can you give me a minimum reproducable example?

@dkirchhof
Copy link
Author

dkirchhof commented Nov 16, 2024

Sure, here it is:
https://github.com/dkirchhof/rewatch-example

just run npm run build

@rolandpeelen
Copy link
Member

Ok got it. Thanks! I'll look into it :)

@rolandpeelen
Copy link
Member

Fixed here: ae6c713

You can try installing 1.0.10-eac37e2.0 which should fix it :)

@dkirchhof
Copy link
Author

Thanks. I can build the source now.
Unfortunately there is a new issue (updated my repo). The compiler complains about jsx syntax. Might be an issue with the ppx similar to this one #104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants