fix support for recursive components in JSX4

Author: mununki

cli/reactjs_jsx_v4.ml

@@ -1043,7 +1043,12 @@ let transformStructureItem ~config mapper item =
           in
           let innerExpression =
             Exp.apply
-              (Exp.ident (Location.mknoloc @@ Lident fnName))
+              (Exp.ident
+                 (Location.mknoloc
+                 @@ Lident
+                      (match recFlag with
+                      | Recursive -> internalFnName
+                      | Nonrecursive -> fnName)))
               ([(Nolabel, Exp.ident (Location.mknoloc @@ Lident "props"))]
               @
               match hasForwardRef with
@@ -1228,7 +1233,8 @@ let transformStructureItem ~config mapper item =
       List.fold_right otherStructures structuresAndBinding ([], [], [])
     in
     types
-    @ [{pstr_loc; pstr_desc = Pstr_value (recFlag, bindings)}]
+    (* No need to be Recursive as internal representation is called *)
+    @ [{pstr_loc; pstr_desc = Pstr_value (Nonrecursive, bindings)}]
     @
     match newBindings with
     | [] -> []

tests/ppx/react/expected/v4.res.txt

@@ -20,16 +20,33 @@ module AnotherName = {
 module Rec = {
   type props = {}
 
-  let rec make = {
+  let make = {
     @merlin.focus
     let rec \"make$Internal" = (_: props) => {
       make(({}: props))
     }
     and make = {
-      let \"V4$Rec" = props => make(props)
+      let \"V4$Rec" = props => \"make$Internal"(props)
 
       \"V4$Rec"
     }
     make
   }
 }
+
+module Rec1 = {
+  type props = {}
+
+  let make = {
+    @merlin.focus
+    let rec \"make$Internal" = (_: props) => {
+      React.null
+    }
+    and make = {
+      let \"V4$Rec1" = props => \"make$Internal"(props)
+
+      \"V4$Rec1"
+    }
+    make
+  }
+}

tests/ppx/react/v4.res

@@ -13,4 +13,11 @@ module Rec = {
   let rec make = () => {
     make({}:props)
   }
+}
+
+module Rec1 = {
+  @react.component
+  let rec make = () => {
+    React.null
+  }
 }