-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add E-commerce Sales
filter to Sales Register Beta Report
#2406
Merged
vorasmit
merged 8 commits into
resilient-tech:develop
from
priyanshshah2442:sales_throgh_ecom_in_sales_register_beta
Jul 26, 2024
Merged
fix: add E-commerce Sales
filter to Sales Register Beta Report
#2406
vorasmit
merged 8 commits into
resilient-tech:develop
from
priyanshshah2442:sales_throgh_ecom_in_sales_register_beta
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2406 +/- ##
===========================================
+ Coverage 61.31% 61.37% +0.05%
===========================================
Files 114 117 +3
Lines 10870 11218 +348
===========================================
+ Hits 6665 6885 +220
- Misses 4205 4333 +128
|
priyanshshah2442
force-pushed
the
sales_throgh_ecom_in_sales_register_beta
branch
from
July 23, 2024 06:17
8341014
to
9141f93
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
* fix: added E-Commerce Sales in filter for invoice_category * fix: E-commerce Sales in Overview * fix: failing test case * fix: remove additional unrequired conditions * fix: minor changes * fix: total row calculation * fix: tuple to set for performance * fix: changes as per review --------- Co-authored-by: Smit Vora <smitvora203@gmail.com> (cherry picked from commit abc3234)
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
* fix: added E-Commerce Sales in filter for invoice_category * fix: E-commerce Sales in Overview * fix: failing test case * fix: remove additional unrequired conditions * fix: minor changes * fix: total row calculation * fix: tuple to set for performance * fix: changes as per review --------- Co-authored-by: Smit Vora <smitvora203@gmail.com> (cherry picked from commit abc3234)
mergify bot
added a commit
that referenced
this pull request
Jul 26, 2024
…tfix/pr-2406 fix: add `E-commerce Sales` filter to Sales Register Beta Report (backport #2406)
mergify bot
added a commit
that referenced
this pull request
Jul 26, 2024
…tfix/pr-2406 fix: add `E-commerce Sales` filter to Sales Register Beta Report (backport #2406)
india-compliance-bot
added a commit
that referenced
this pull request
Aug 4, 2024
## [14.30.2](v14.30.1...v14.30.2) (2024-08-04) ### Bug Fixes * add `E-commerce Sales` filter to Sales Register Beta Report ([#2406](#2406)) ([96106e2](96106e2)) * cleaner and consistent entry point for gstr-1, support disable save fully ([319bce9](319bce9)) * gst invoice warning based on gst_tax_type ([ee606e6](ee606e6)) * patch to move old logs from GSTR-1 Log to GST Return Log ([2be7e7d](2be7e7d))
india-compliance-bot
added a commit
that referenced
this pull request
Aug 4, 2024
## [15.12.1](v15.12.0...v15.12.1) (2024-08-04) ### Bug Fixes * add `E-commerce Sales` filter to Sales Register Beta Report ([#2406](#2406)) ([e8fdabc](e8fdabc)) * always use `frappe.get_meta` in `set_tax_amount_precisions` ([#2497](#2497)) ([397052c](397052c)) * cleaner and consistent entry point for gstr-1, support disable save fully ([6248f8b](6248f8b)) * Client-Side Changes Related to Subcontracting ([#2496](#2496)) ([4123672](4123672)) * gst invoice warning based on gst_tax_type ([32528e5](32528e5)) * Handle error 2283 while generating e-Invoice ([#2452](#2452)) ([e171ff1](e171ff1)), closes [#2364](#2364) * Mapping of Sales and Purchase Templates ([#2485](#2485)) ([e74610e](e74610e)) * patch to move old logs from GSTR-1 Log to GST Return Log ([d92cd9d](d92cd9d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huly®: IC-2519