Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add E-commerce Sales filter to Sales Register Beta Report #2406

Conversation

priyanshshah2442
Copy link
Contributor

@priyanshshah2442 priyanshshah2442 commented Jul 12, 2024

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 69.04762% with 13 lines in your changes missing coverage. Please review.

Project coverage is 61.37%. Comparing base (3d518d7) to head (a1fe9eb).
Report is 36 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2406      +/-   ##
===========================================
+ Coverage    61.31%   61.37%   +0.05%     
===========================================
  Files          114      117       +3     
  Lines        10870    11218     +348     
===========================================
+ Hits          6665     6885     +220     
- Misses        4205     4333     +128     
Files Coverage Δ
...ndia_compliance/gst_india/utils/gstr_1/__init__.py 100.00% <100.00%> (ø)
...gst_sales_register_beta/gst_sales_register_beta.py 84.21% <57.14%> (-4.26%) ⬇️
...a_compliance/gst_india/utils/gstr_1/gstr_1_data.py 83.26% <69.69%> (-2.45%) ⬇️

... and 22 files with indirect coverage changes

Impacted file tree graph

@priyanshshah2442 priyanshshah2442 marked this pull request as ready for review July 22, 2024 07:33
@priyanshshah2442 priyanshshah2442 force-pushed the sales_throgh_ecom_in_sales_register_beta branch from 8341014 to 9141f93 Compare July 23, 2024 06:17
@vorasmit vorasmit merged commit abc3234 into resilient-tech:develop Jul 26, 2024
11 checks passed
mergify bot pushed a commit that referenced this pull request Jul 26, 2024
* fix: added E-Commerce Sales in filter for invoice_category

* fix: E-commerce Sales in Overview

* fix: failing test case

* fix: remove additional unrequired conditions

* fix: minor changes

* fix: total row calculation

* fix: tuple to set for performance

* fix: changes as per review

---------

Co-authored-by: Smit Vora <smitvora203@gmail.com>
(cherry picked from commit abc3234)
mergify bot pushed a commit that referenced this pull request Jul 26, 2024
* fix: added E-Commerce Sales in filter for invoice_category

* fix: E-commerce Sales in Overview

* fix: failing test case

* fix: remove additional unrequired conditions

* fix: minor changes

* fix: total row calculation

* fix: tuple to set for performance

* fix: changes as per review

---------

Co-authored-by: Smit Vora <smitvora203@gmail.com>
(cherry picked from commit abc3234)
mergify bot added a commit that referenced this pull request Jul 26, 2024
…tfix/pr-2406

fix: add `E-commerce Sales`  filter to Sales Register Beta Report (backport #2406)
mergify bot added a commit that referenced this pull request Jul 26, 2024
…tfix/pr-2406

fix: add `E-commerce Sales`  filter to Sales Register Beta Report (backport #2406)
india-compliance-bot added a commit that referenced this pull request Aug 4, 2024
## [14.30.2](v14.30.1...v14.30.2) (2024-08-04)

### Bug Fixes

* add `E-commerce Sales`  filter to Sales Register Beta Report ([#2406](#2406)) ([96106e2](96106e2))
* cleaner and consistent entry point for gstr-1, support disable save fully ([319bce9](319bce9))
* gst invoice warning based on gst_tax_type ([ee606e6](ee606e6))
* patch to move old logs from GSTR-1 Log to GST Return Log ([2be7e7d](2be7e7d))
india-compliance-bot added a commit that referenced this pull request Aug 4, 2024
## [15.12.1](v15.12.0...v15.12.1) (2024-08-04)

### Bug Fixes

* add `E-commerce Sales`  filter to Sales Register Beta Report ([#2406](#2406)) ([e8fdabc](e8fdabc))
* always use `frappe.get_meta` in `set_tax_amount_precisions` ([#2497](#2497)) ([397052c](397052c))
* cleaner and consistent entry point for gstr-1, support disable save fully ([6248f8b](6248f8b))
* Client-Side Changes Related to Subcontracting ([#2496](#2496)) ([4123672](4123672))
* gst invoice warning based on gst_tax_type ([32528e5](32528e5))
* Handle error 2283 while generating e-Invoice ([#2452](#2452)) ([e171ff1](e171ff1)), closes [#2364](#2364)
* Mapping of Sales and Purchase Templates ([#2485](#2485)) ([e74610e](e74610e))
* patch to move old logs from GSTR-1 Log to GST Return Log ([d92cd9d](d92cd9d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants