Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore validation validate_for_invalid_account_type for GST category: SEZ #2523

Merged

Conversation

vishakhdesai
Copy link
Contributor

@vishakhdesai vishakhdesai commented Aug 16, 2024

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.90%. Comparing base (870cfd9) to head (d8eafbb).
Report is 38 commits behind head on develop.

Files Patch % Lines
...ndia_compliance/gst_india/overrides/transaction.py 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2523      +/-   ##
===========================================
- Coverage    61.14%   59.90%   -1.24%     
===========================================
  Files          118      120       +2     
  Lines        11347    11488     +141     
===========================================
- Hits          6938     6882      -56     
- Misses        4409     4606     +197     
Files Coverage Δ
...ndia_compliance/gst_india/overrides/transaction.py 89.08% <75.00%> (-0.16%) ⬇️

... and 10 files with indirect coverage changes

Impacted file tree graph

@vorasmit vorasmit merged commit 10cde4a into resilient-tech:develop Aug 22, 2024
10 checks passed
mergify bot pushed a commit that referenced this pull request Aug 22, 2024
…tegory: SEZ (#2523)

* fix: ignore validate_for_invalid_account_type for SEZ

* fix: fix failing test case

* fix: correctly guess company gst category for all doctypes

---------

Co-authored-by: Smit Vora <smitvora203@gmail.com>
(cherry picked from commit 10cde4a)
mergify bot pushed a commit that referenced this pull request Aug 22, 2024
…tegory: SEZ (#2523)

* fix: ignore validate_for_invalid_account_type for SEZ

* fix: fix failing test case

* fix: correctly guess company gst category for all doctypes

---------

Co-authored-by: Smit Vora <smitvora203@gmail.com>
(cherry picked from commit 10cde4a)
mergify bot added a commit that referenced this pull request Aug 22, 2024
…tfix/pr-2523

fix: Ignore validation `validate_for_invalid_account_type` for GST category: SEZ (backport #2523)
mergify bot added a commit that referenced this pull request Aug 22, 2024
…tfix/pr-2523

fix: Ignore validation `validate_for_invalid_account_type` for GST category: SEZ (backport #2523)
india-compliance-bot added a commit that referenced this pull request Aug 22, 2024
# [15.13.0](v15.12.1...v15.13.0) (2024-08-22)

### Bug Fixes

* Accept Supplier Values is removed ([2cb4feb](2cb4feb))
* add mandatory field in test case ([aa27db6](aa27db6))
* add report to workspace ([65f04bf](65f04bf))
* better permission check for viewing pending vouchers ([5155668](5155668))
* changes as per comments ([acb7a50](acb7a50))
* check company_name in purchase invoice and boe ([f3882b6](f3882b6))
* display last updated time for pan status ([900c959](900c959))
* filter inward supply with company with tentetive gstins ([f3da8a0](f3da8a0))
* fixed aadhar card number ([78eff3a](78eff3a))
* Ignore validation `validate_for_invalid_account_type` for GST category: SEZ ([#2523](#2523)) ([18a5e64](18a5e64))
* ITC-04 beta report ([18c70b8](18c70b8))
* ITC-04 data generation ([32b54ee](32b54ee))
* Link Integration Requests with GST Returns Log ([06a3685](06a3685))
* make period field mandatory ([5c23138](5c23138))
* minor changes to configurations of pan doc ([9b15669](9b15669))
* new pan doctype ([64a1ff8](64a1ff8))
* pan doc consistent with GSTIN ([531efe2](531efe2))
* parenttype in where query for child table ([7d5b14b](7d5b14b))
* **pur reco:** ensure that latest purchae period is selected onload ([9d30730](9d30730))
* report changes ([8edfa9b](8edfa9b))
* set rate when list not empty ([e336735](e336735))
* show item type in itc query ([4d1dd67](4d1dd67))
* show pan status ([d5b8e27](d5b8e27))
* Support new categories of documents for GSTR-1 Document Issued Summary ([#2529](#2529)) ([19ce53e](19ce53e))
* use item gst details in pur reco ([98c3d83](98c3d83))
* UX fixes for Taxes in Subcontracting Docs ([#2511](#2511)) ([8eb7358](8eb7358))
* **ux:** enhance ux with default filters and other fixes ([fa1e720](fa1e720))

### Features

* **ITC-04:** create necessary fields to update original reference ([#2479](#2479)) ([883d612](883d612))

### Performance Improvements

* update values with one db query ([1b39bd1](1b39bd1))
india-compliance-bot added a commit that referenced this pull request Aug 22, 2024
## [14.30.3](v14.30.2...v14.30.3) (2024-08-22)

### Bug Fixes

* Accept Supplier Values is removed ([7e139c3](7e139c3))
* add mandatory field in test case ([4bbf0b5](4bbf0b5))
* better permission check for viewing pending vouchers ([da31702](da31702))
* check company_name in purchase invoice and boe ([8f7e1ab](8f7e1ab))
* filter inward supply with company with tentetive gstins ([43414e7](43414e7))
* Ignore validation `validate_for_invalid_account_type` for GST category: SEZ ([#2523](#2523)) ([b83095e](b83095e))
* make period field mandatory ([ecccb06](ecccb06))
* parenttype in where query for child table ([c7f7b7b](c7f7b7b))
* **pur reco:** ensure that latest purchae period is selected onload ([6da756d](6da756d))
* Support new categories of documents for GSTR-1 Document Issued Summary ([#2529](#2529)) ([f3536dc](f3536dc))
* use item gst details in pur reco ([e7b09c8](e7b09c8))

### Performance Improvements

* update values with one db query ([eacec63](eacec63))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't raise if company GST Category is SEZ
2 participants