Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update HSN validation message for better ux #2873

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

vorasmit
Copy link
Member

@vorasmit vorasmit commented Dec 16, 2024

@vorasmit vorasmit marked this pull request as ready for review December 16, 2024 14:02
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.14%. Comparing base (a8e5490) to head (490fd46).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2873   +/-   ##
========================================
  Coverage    60.14%   60.14%           
========================================
  Files          122      122           
  Lines        12060    12060           
========================================
  Hits          7254     7254           
  Misses        4806     4806           
Files with missing lines Coverage Δ
...ndia_compliance/gst_india/overrides/transaction.py 88.11% <ø> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

@vorasmit vorasmit merged commit fec611f into resilient-tech:develop Dec 20, 2024
11 checks passed
mergify bot pushed a commit that referenced this pull request Dec 20, 2024
* fix: update HSN validation message for better ux

* test: update error message for the test cases

(cherry picked from commit fec611f)
mergify bot pushed a commit that referenced this pull request Dec 20, 2024
* fix: update HSN validation message for better ux

* test: update error message for the test cases

(cherry picked from commit fec611f)
mergify bot added a commit that referenced this pull request Dec 20, 2024
…tfix/pr-2873

fix: update HSN validation message for better ux (backport #2873)
mergify bot added a commit that referenced this pull request Dec 20, 2024
…tfix/pr-2873

fix: update HSN validation message for better ux (backport #2873)
india-compliance-bot added a commit that referenced this pull request Dec 20, 2024
## [15.14.6](v15.14.5...v15.14.6) (2024-12-20)

### Bug Fixes

* cancel e-invoice on cancel of invoice from list view ([#2668](#2668)) ([2bd2120](2bd2120))
* change function name as per version ([7756402](7756402))
* Fields to identify from where document is downloaded ([#2839](#2839)) ([2c0cc01](2c0cc01))
* ignore root company validation ([261b3a9](261b3a9))
* ignore system error that randomly comes for section CDNR ([217959f](217959f))
* patch recinciliation status for manually updating the data ([f1170be](f1170be))
* Remove Filter on Second Click ([#2874](#2874)) ([f5f696b](f5f696b))
* set recon status for match found in purchase reco tool ([2a838a9](2a838a9))
* show error message instead of throw during Purchase Invoice name validation  ([#2864](#2864)) ([62408b7](62408b7))
* tabs should be field group instead of datatable ([fe8c60e](fe8c60e))
* update HSN validation message for better ux ([#2873](#2873)) ([3fed0e8](3fed0e8))
* update minimum and maximum net rate field in item ([#2870](#2870)) ([1340540](1340540))
* use shipping address instread of port address for e-invoice ([#2799](#2799)) ([87c1dab](87c1dab))
* validate item tax template item_name wise if item_code is not set ([1b4934b](1b4934b))
india-compliance-bot added a commit that referenced this pull request Dec 20, 2024
## [14.30.12](v14.30.11...v14.30.12) (2024-12-20)

### Bug Fixes

* ignore root company validation ([d5eb394](d5eb394))
* ignore system error that randomly comes for section CDNR ([37fbb64](37fbb64))
* patch recinciliation status for manually updating the data ([11b4b69](11b4b69))
* set recon status for match found in purchase reco tool ([1fabc81](1fabc81))
* show error message instead of throw during Purchase Invoice name validation  ([#2864](#2864)) ([703c0b5](703c0b5))
* tabs should be field group instead of datatable ([d7337dd](d7337dd))
* update HSN validation message for better ux ([#2873](#2873)) ([2eac9ca](2eac9ca))
* update minimum and maximum net rate field in item ([#2870](#2870)) ([9639c6c](9639c6c))
* use shipping address instread of port address for e-invoice ([#2799](#2799)) ([94cd7d4](94cd7d4))
* validate item tax template item_name wise if item_code is not set ([52704ca](52704ca))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant