Streaming pull #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start extracting as soon as the data starts coming from the network. This reduces the free space required for a docker pull to happen since there are no temp files. Digest verification happens when the last byte of the layer is read. If verification fails we return an error that will cascade to the layer store and cancel the pull. Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Taken from https://github.com/Azure/go-autorest/blob/v8.1.1/autorest/utility.go#L52-L70 Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Attempt to resume a download if it stops midway for up to maxDownloadAttempts times. Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the pull behaviour to download and extract at the same time, without first buffering the layer to disk. This reduces the required space for a pull to be exactly the size of the downloaded layers and minimises disk IO.