Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorite button is a toggle but there is no indication whether the track is already in Favorites or not #282

Open
hsandt opened this issue Dec 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@hsandt
Copy link

hsandt commented Dec 24, 2023

Operating system

Linux Ubuntu 22.04

Browser name and version

Chrome Version 120.0.6099.109 (Official Build) (64-bit)

Expected behavior

  • a track should have an obvious icon showing if it's already favorited or not (e.g. a filled/empty heart/star)
  • the Favorite button icon/text should reflect the new state of the track (e.g. a filled star "Favorite" or an empty star "Remove from Favorites)
  • ideally, instead of opening the 3-dots menu you would see the Favorite icon near the track so it would act both as a current status icon and a button to toggle the state: empty star -> click to Favorite -> filled star -> click to remove from Favorites -> empty star. And on hover you could add some tooltip "Favorite/Remove from favorites" if it's not obvious

Actual behavior

  • you must click on 3-dots menu to see the Favorite button and even then it doesn't tell you if the track is favorited or not
  • the only way to know is to either check the Favorites list manually, or click on Favorite and see if the text says track was added or removed from Favorites (if it did the opposite or what you wanted, you must then click on Favorite once more to revert)

Steps to reproduce behavior

  • open any album page
  • observe tracks (no Favorite indication)
  • click on 3-dots menu
  • check the Favorite button
  • click on Favorite
  • repeat on a track already in Favorites
@auggod auggod added the bug Something isn't working label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants