Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Consistency Issue. #1326

Open
Panha-Sim opened this issue Oct 18, 2024 · 6 comments
Open

UI Consistency Issue. #1326

Panha-Sim opened this issue Oct 18, 2024 · 6 comments

Comments

@Panha-Sim
Copy link

🐞 bug report

✍️ Description

This is more of a UI consistency issue. The Fullscreen icon of mobile view is all the way over to the right where as the Fullscreen toggle for the Ipad and laptop is in correct position.

πŸ•΅πŸΌβ€β™‚οΈ Is this a regression?

I don't know.

πŸ”¬ Minimal Reproduction

Add a mobile device in the device manager

🌍 Your Environment


App Version: 1.15.0
Electron Version: 27.0.4
Chrome Version: 118.0.5993.129
Node.js Version: 18.17.1
V8 Version: 11.8.172.17-electron.0
OS: Windows_NT x64 10.0.22631

πŸ”₯ Exception or Error or Screenshot

image



@SwastikaPradhan
Copy link

/assign

@violetadev
Copy link
Contributor

Hi, please start working on it, no need to assign the issue.

@happymvp
Copy link
Contributor

happymvp commented Dec 1, 2024

I'm going to work on this one. In case I'll fail for some reasons I'll update here, till then please don't do double job =)

@happymvp
Copy link
Contributor

happymvp commented Dec 1, 2024

🐞 bug report

✍️ Description

This is more of a UI consistency issue. The Fullscreen icon of mobile view is all the way over to the right where as the Fullscreen toggle for the Ipad and laptop is in correct position.

πŸ•΅πŸΌβ€β™‚οΈ Is this a regression?

I don't know.

πŸ”¬ Minimal Reproduction

Add a mobile device in the device manager

🌍 Your Environment


App Version: 1.15.0
Electron Version: 27.0.4
Chrome Version: 118.0.5993.129
Node.js Version: 18.17.1
V8 Version: 11.8.172.17-electron.0
OS: Windows_NT x64 10.0.22631

πŸ”₯ Exception or Error or Screenshot

image


Could you check please what is your zoom % ?

@happymvp
Copy link
Contributor

happymvp commented Dec 1, 2024

My guess is:

On your screenshot you had zoomed out a browser, that leaded to downscaling of web view. So web view became smaller than toolbar.

But static size of toolbar is expected behaviour. As you can see it is applicable to any device, not just mobile.

Screenshot 2024-12-01 at 19 24 23

@violetadev @Panha-Sim @manojVivek @esprush I propose to implement UI widget to visualise user's browser size.
(https://drive.google.com/file/d/1O3GuzNxsQ2-EsEZcW3KduNYM4jUcRRrB/view?usp=sharing) - example recording

@violetadev
Copy link
Contributor

@happymvp sounds good, go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants