rufus scheduler "overlap" option not working

[dnajd]

I noticed this setting in rufus scheduler. Is it possible to use with resque scheduler?
https://github.com/jmettraux/rufus-scheduler#overlap--false

I tried this

  name = "Blah"
  config = {}
  config[:class] = 'TheJob'
  config[:args] = 'arg'
  config[:every] = ['1m', {first_in: 1.minutes}]
  config[:persist] = true
  config[:queue] = 'queue'
  config[:overlap] = false
  Resque.set_schedule(name, config)

But it did't work...

[meatballhat]

@dnajd afaict there's nothing in the resque-scheduler code to prevent this from working. Can you verify that the version of rufus-scheduler in your environment includes support for overlap?

[peret]

Hi, I'm running into the same problem. I'm using resque-scheduler 4.3.0 and rufus-scheduler 3.3.0. So yes, the rufus-scheduler gem should support the overlap option.
I tested this by creating a resque job which sleeps for 10 seconds and then scheduling it every second, with the overlap option. Like this:

namespace :resque do
  task setup: [:environment] do
    Resque.schedule = {
      sleepy_worker: {
        class: 'SleepyWorker',
        queue: 'sleepy_worker',
        every: '1s',
        overlap: false
      }
   }
  end
end

I would expect that no new jobs get scheduled, as long as a job is still running on the same queue. They are, however, and the job queue fills up pretty quickly.

[peret]

I'm not familiar with the code at all, but is it maybe the case that the job that is scheduled with rufus is just a piece of code that enqueues a new job into the resque queue?

In that case, the overlap option would make sure that no two of these jobs run at the same time, which is not very useful because enqueuing a new resque job doesn't take that long anyway. But of course rufus has no concept of the state of the resque queue and of the actual work being done there, so it just keeps adding jobs.

I guess the question, in that case, is what the intended behavior really is. Is this a bug that needs to be fixed in resque-scheduler, or is this just a mismatch between the behavior I expected and the intended behavior? I think, at the very least, this behavior should be documented in the README.

[peret]

I whipped something up for my use case real quick and created a PR in case you decide to support this behavior.

[carsonreinke]

Wouldn't using a combination of Resque plugins be a better solution? I feel like there is so many cases that could happen external to resque-scheduler.

[peret]

Maybe you are right. In that case it might be a good idea to update the README though: "All rufus-scheduler options are supported when setting schedules." Maybe it should be clarified, that the overlap option doesn't have the expected effect?

[carsonreinke]

Noted here #612