Skip to content

Commit ad74a31

Browse files
committed
Rename created Docker image into test-services-python
I was confused by our naming pattern of the Docker image. The image that we are publishing is called test-services-python and the one we build in the integration workflow is called python-test-services. When reading the workflow run on GHA it took me quite some time to figure out where this image comes from.
1 parent 371f655 commit ad74a31

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

.github/workflows/integration.yaml

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,34 +7,33 @@ on:
77
branches:
88
- main
99
schedule:
10-
- cron: '0 */6 * * *' # Every 6 hours
10+
- cron: "0 */6 * * *" # Every 6 hours
1111
workflow_dispatch:
1212
inputs:
1313
restateCommit:
14-
description: 'restate commit'
14+
description: "restate commit"
1515
required: false
16-
default: ''
16+
default: ""
1717
type: string
1818
restateImage:
19-
description: 'restate image, superseded by restate commit'
19+
description: "restate image, superseded by restate commit"
2020
required: false
21-
default: 'ghcr.io/restatedev/restate:main'
21+
default: "ghcr.io/restatedev/restate:main"
2222
type: string
2323
workflow_call:
2424
inputs:
2525
restateCommit:
26-
description: 'restate commit'
26+
description: "restate commit"
2727
required: false
28-
default: ''
28+
default: ""
2929
type: string
3030
restateImage:
31-
description: 'restate image, superseded by restate commit'
31+
description: "restate image, superseded by restate commit"
3232
required: false
33-
default: 'ghcr.io/restatedev/restate:main'
33+
default: "ghcr.io/restatedev/restate:main"
3434
type: string
3535

3636
jobs:
37-
3837
sdk-test-suite:
3938
if: github.repository_owner == 'restatedev'
4039
runs-on: ubuntu-latest
@@ -99,14 +98,14 @@ jobs:
9998
file: "test-services/Dockerfile"
10099
push: false
101100
load: true
102-
tags: restatedev/python-test-services
101+
tags: restatedev/test-services-python
103102
cache-from: type=gha,scope=${{ github.workflow }}
104103
cache-to: type=gha,mode=max,scope=${{ github.workflow }}
105104

106105
- name: Run test tool
107106
uses: restatedev/sdk-test-suite@v3.0
108107
with:
109108
restateContainerImage: ${{ inputs.restateCommit != '' && 'localhost/restatedev/restate-commit-download:latest' || (inputs.restateImage != '' && inputs.restateImage || 'ghcr.io/restatedev/restate:main') }}
110-
serviceContainerImage: "restatedev/python-test-services"
109+
serviceContainerImage: "restatedev/test-services-python"
111110
exclusionsFile: "test-services/exclusions.yaml"
112111
testArtifactOutput: "sdk-python-integration-test-report"

0 commit comments

Comments
 (0)