restate-sdk-clients Provide request timeout option

[mupperton]

Currently there does not seem to be a way of configuring a timeout on invoking a handler from the restate-sdk-clients package

E.g.

await connect({ url: 'http://restate-server-url' }).serviceClient({ name: 'svc' }).myHandler()

In a restate-service you can do this with .orTimeout() on the end

So these requests appear to just hang forever (if there is a temporary issue on the handler for example) until the invocation resolves

[igalshilman]

Hey @mupperton, this is definitly doable.

under the hood we are just using fetch, so it should be possible to pass trough a timeout (or more generally an AbortSignal) trough the rpc options.

Maybe an API like that:

serviceClient(...).myHandler("foo", restate.rpc.opts({ timeout: 123 }))

Also, note that these are normal promises (not restate promises) that are coming from wrapping fetch so you can also use the regular node js promise combinators. For example here is how to add a timeout for a promise:

(source: https://stackoverflow.com/a/46675277)

const withTimeout = (millis, promise) => {
    let timeoutPid;
    const timeout = new Promise((resolve, reject) =>
        timeoutPid = setTimeout(
            () => reject(`Timed out after ${millis} ms.`),
            millis));
    return Promise.race([
        promise,
        timeout
    ]).finally(() => {
        if (timeoutPid) {
            clearTimeout(timeoutPid);
        }
    });
};