fix(setting): preserve setting keys consistency

Author: Gerald Baulig

cfg/config.json

@@ -367,7 +367,7 @@
       "shop_invoice_create_enabled": true,
       "shop_invoice_render_enabled": true,
       "shop_invoice_send_enabled": true,
-      "shop_order_error_cleanup": true
+      "shop_order_error_cleanup_enabled": true
     }
   }
 }

src/service.ts

@@ -2042,7 +2042,7 @@ export class OrderingService
       this.logger?.debug('Cleanup failed orders...');
       const failed_order_ids = Object.values(response_map)?.filter(
         order => order.status?.code !== 200
-          && settings.get(order.status?.id)?.shop_order_error_cleanup
+          && settings.get(order.status?.id)?.shop_order_error_cleanup_enabled
       ).map(
         order => order.payload?.id ?? order.status?.id
       ) ?? [];

src/utils.ts

@@ -137,7 +137,7 @@ export const DefaultUrns = {
   shop_invoice_create_enabled:      'urn:restorecommerce:shop:setting:order:submit:invoice:create:enabled',     // Creates invoice on order submit if enabled (default: true)
   shop_invoice_render_enabled:      'urn:restorecommerce:shop:setting:order:submit:invoice:render:enabled',     // Renders invoice on order submit if enabled, overrides create! (default: true)
   shop_invoice_send_enabled:        'urn:restorecommerce:shop:setting:order:submit:invoice:send:enabled',       // Sends invoice on order submit if enabled, overrides render! (default: true)
-  shop_order_error_cleanup:         'urn:restorecommerce:shop:setting:order:error:cleanup:enabled',             // Clean up orders on any error of fulfillment or invoice (default: false)
+  shop_order_error_cleanup_enabled: 'urn:restorecommerce:shop:setting:order:error:cleanup:enabled',             // Clean up orders on any error of fulfillment or invoice (default: false)
 };
 export type KnownUrns = typeof DefaultUrns;
 
@@ -146,7 +146,7 @@ export const DefaultSetting = {
   shop_invoice_create_enabled: true,
   shop_invoice_render_enabled: true,
   shop_invoice_send_enabled: true,
-  shop_order_error_cleanup: true,
+  shop_order_error_cleanup_enabled: true,
 }
 export type ResolvedSetting = typeof DefaultSetting;
 export type ResolvedSettingMap = Map<string, ResolvedSetting>;

src/worker.ts

@@ -43,8 +43,7 @@ registerProtoMeta(
 );
 
 export type Handler = (msg: any, context: any, config: any, eventName: string) => any;
-export type HandlerMap = { [key: string]: Handler };
-
+export type HandlerMap = Record<string, Handler>;
 export class Worker {
   private _cfg?: ServiceConfig;
   private _offsetStore?: OffsetStore;

test/ordering-srv.spec.ts

@@ -104,7 +104,7 @@ describe('The Ordering Service:', () => {
         worker?.stop(),
       ])
     ).finally(
-      () => mocking?.forEach(mock => mock?.stop())
+      () => Promise.allSettled(mocking?.map(mock => mock?.stop()))
     );
   });