-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strongly Name the assemblies #216
Comments
There are no plans to do this. See: http://nuget.codeplex.com/discussions/247827 |
@SWAJ Do you still need a strong named version of RestSharp or have you moved on? @young what about you? The reason I bring this up is that a clever solution that the JSON.NET library does is to strongly name the assembly, but lock the assembly version. That way, only the package version changes. This resolves most of the binding redirect pains of using RestSharp. Of course, it's a one-time breaking change. Check out this discussion about signing WebActivator: https://github.com/davidebbo/WebActivator/wiki/Signing-WebActivator This would pretty much require that we create a new package name. We'd need to come up with a name for it. |
No I don't. Honestly I would rather drop strong-naming altogether. If somebody that uses my library needs assemblies strongly named, they can do it themselves. |
For me this is still a minor issue, I'm trying to get most of my assemblies signed. |
I would also like to drop strong-naming altogether. Unfortunately I can't! I use RestSharp in a SharePoint project that requires DLLs to be deployed to the GAC and therefore must be strong named. There is the RestSharpSigned package but it is a community effort and not updated as frequently. Considering this makes it difficult for some users to keep updated with the latest version of RestSharp, I would really appreciate it if the decision to drop strong naming could be reconsidered? Pretty please! Also wondering what happened in Pull Request #422 related to this? |
Strong names only cause a problem when they are not used properly. Unfortunately it's also easy to misuse them. However, we can't forget the following.
Failing to use strong names for an assembly distributed through NuGet is detrimental to overall usefulness of the package. The solution is simple: understand the limitations of strong names and develop a breaking changes policy and NuGet package specification which eliminates the problems typically associated with strong named assemblies.
|
If you have any questions about strong names or the associated policies, feel free to @-reference me and I'll be happy to help review any material. |
I've reached out to the owner of the RestSharpSigned nuget package to see what he's doing. I've also offered to take it over and to try and keep it up to date with the core library. |
I've got control of the RestSharpSigned package and will update it as soon as nuget comes back online. There are commits from tonight that create a new solution and project files that support the strong naming. |
The problem today is that now I have nuget packages that depend on RestSharp and now I can't add any that depend on RestSharpSigned and vice-versa. 😭 |
Is it possible for you guys to strongly name your assemblies? I'm looking to use the RestClient within my ActionMailer.Net library, but I can't because it's not strongly named, and my assembly is. I could distribute my own version, but I'd rather not do that.
Cheers!
Scott
The text was updated successfully, but these errors were encountered: