Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop returning non-0 values from hooks #333

Open
atenart opened this issue Jan 16, 2024 · 0 comments
Open

Stop returning non-0 values from hooks #333

atenart opened this issue Jan 16, 2024 · 0 comments
Labels
bug Something isn't working
Milestone
v1.6

Comments

@atenart
Copy link
Contributor

atenart commented Jan 16, 2024

As shown in #332, returning non-0 values from hooks is problematic with recent kernels. This is problematic with our convention of allowing hooks to return -ENOMSG.

We should evaluate how to always return 0 from hooks while still providing a way to discard the event or by finding a better solution for letting hooks filter events.
@atenart atenart added the bug Something isn't working label Jan 16, 2024
@atenart atenart added this to the v1.4 milestone Jan 16, 2024
@atenart atenart modified the milestones: v1.4, v1.5 Apr 3, 2024
@atenart atenart modified the milestones: v1.5, v1.6 Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.6
Development

No branches or pull requests
1 participant
@atenart