fix: Do not rely on JavaScript to determine header width #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, there is a CSS minification issue caused by this change - |
|
Thanks for the reminder!
Yeah, let it be :) |
ulmefors
pushed a commit
to ulmefors/hugo-theme-meme
that referenced
this pull request
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, without JavaScript the header stays invisible (
opacity: 0). The other issue: if you load the page while the browser window is small and maximize it then, the header will stay narrow and wrapped onto multiple lines. Both issues are due to the hack measuring.inner-widthfor the header size.Let's go with a CSS-only solution instead?