Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename $Deliver into $ for clarity #177

Merged
merged 2 commits into from
May 26, 2020
Merged

Conversation

palant
Copy link
Collaborator

@palant palant commented May 26, 2020

For most part, this is an automated search & replace:

  • $Deliver => $
  • "Deliver" => "$"
  • $ := .Deliver => $ := index . "$"

The only manual changes are in assets/js/lunr-search.js and layouts/partials/utils/list-item.html.

@palant
Copy link
Collaborator Author

palant commented May 26, 2020

A few files had {{- $ := . -}} assignment at the top level now - I removed it, Hugo templates do this implicitly by default.

@palant palant requested a review from reuixiy May 26, 2020 05:41
@palant
Copy link
Collaborator Author

palant commented May 26, 2020

Maybe you could test whether layouts/partials/utils/tree-sections.html still works correctly - the structure is unusual there.

@palant palant merged commit 81a773d into master May 26, 2020
@palant palant deleted the deliver-variable branch May 26, 2020 08:42
ulmefors pushed a commit to ulmefors/hugo-theme-meme that referenced this pull request Nov 22, 2020
BREAKING CHANGE: `Deliver` parameter to various templates is now called `$`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants