Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed run ci in action github #116

Closed
brunoalvesdasilva opened this issue Feb 7, 2024 · 14 comments
Closed

Failed run ci in action github #116

brunoalvesdasilva opened this issue Feb 7, 2024 · 14 comments

Comments

@brunoalvesdasilva
Copy link

Hello everyone, I have a question.

We are receiving this error in our company's action, and apparently we have not made any changes.

Is there anything we can do to solve it? We temporarily fixed the version at 1.18.1 and it is correct, but in the last version it does not work, always generating this error.

image

in action code:

    - name: Run reviewdog stylelint
        uses: reviewdog/action-stylelint@v1
        with:
          github_token: ****
          reporter: github-pr-check
          filter_mode: nofilter
          stylelint_input: src/**
          fail_on_error: true
@gvNN7
Copy link

gvNN7 commented Feb 7, 2024

it's seems related to this RDJSON implementation #111

@bert-mccutchen
Copy link
Contributor

Not being dismissive of your issue. However, you may be able to solve your issue quicker by upgrading your Stylelint version.

Your Stylelint version is 14.5.3, have you considered upgrading to at least 15 with Stylelint now at 16.2.1?

Upgrade Guides

  1. Upgrading Stylelint 14 to Stylelint 15
  2. Upgrading Stylelint 15 to Stylelint 16

@davidcornu
Copy link
Contributor

@brunoalvesdasilva #118 might help you diagnose this

@brunoalvesdasilva
Copy link
Author

@davidcornu Of course, I'll try to update, the only problem is that a package indicated by stylelint is deprecated to work with jsx, we're still working on that.

I'll add the pull request code and let you know if everything went well

@taltcher
Copy link
Contributor

Can someone look at it? this action is still completely broken in CI....

@bert-mccutchen
Copy link
Contributor

With the latest release that contains @davidcornu's changes, you should be able to see any errors that Stylelint runs into.

@taltcher, on v1.22.1, are you getting an error from Stylelint printed out? Or are you still receiving the "failed to unmarshal rdjson" error?

@taltcher
Copy link
Contributor

taltcher commented Mar 4, 2024

@bert-mccutchen - I'm getting:

reviewdog: parse error: failed to unmarshal rdjson (DiagnosticResult): proto: syntax error (line 1:1): invalid value /

@taltcher taltcher closed this as completed Mar 4, 2024
@taltcher taltcher reopened this Mar 4, 2024
@taltcher
Copy link
Contributor

taltcher commented Mar 4, 2024

@bert-mccutchen - is there any additional information I can provide?

@davidcornu
Copy link
Contributor

@taltcher which version of reviewdog/action-stylelint are you running?

@taltcher
Copy link
Contributor

taltcher commented Mar 7, 2024

@davidcornu latest one

@davidcornu
Copy link
Contributor

@taltcher hmm ok that would suggest you're hitting a case my PR didn't handle. The way I debugged this was to fork the repo, add a bunch of extra logging, and update the gh actions step to use the fork. This helped me realize there was a stylelint error being passed to reviewdog. You might have success doing something similar.

@taltcher
Copy link
Contributor

@davidcornu you want me to try and run the forked branch as well? which branch is it?

@taltcher
Copy link
Contributor

Hi @davidcornu - I have validated again that I'm on the latest version of stylelint and now it seems to be working properly :-)

@davidcornu
Copy link
Contributor

@taltcher gonna mark this one as closed. Feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants