You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But any non zero code would cause a termination before reaching that line.
Essentially the following might give the impression that some cleanup is done if the reviewdog command fails, but it's not, if the exit code is anything other than 0, the following block never gets run:
EXIT_CODE=$?
if [ "${INPUT_CLEANUP}" = "true" ]; then
git stash drop || true
else
git stash pop || true
fi
exit "${EXIT_CODE}"
Instead it would appear that the command should use an && as well as an || to capture the exit code on the same line and ensure the line exit code is 0:
The action script contains
set -e
which tells bash to exit if any command fails:action-suggester/script.sh
Line 2 in 3d7fde6
Further down however it expects to be able to capture the exit code of executing the reviewdog binary:
action-suggester/script.sh
Line 26 in 3d7fde6
But any non zero code would cause a termination before reaching that line.
Essentially the following might give the impression that some cleanup is done if the reviewdog command fails, but it's not, if the exit code is anything other than 0, the following block never gets run:
Previously there was an
|| EXIT_CODE=$?
that was removed as part of https://github.com/reviewdog/action-suggester/pull/31/files but this doesn't see correct iferrexit
is setInstead it would appear that the command should use an
&&
as well as an||
to capture the exit code on the same line and ensure the line exit code is 0:The text was updated successfully, but these errors were encountered: