Skip to content

Conversation

lkuechler
Copy link
Contributor

Really cool project. Thank you for creating it.
Small extension to the readme to make it clear that voice-chats are not supported without some extra steps in a different thread and still not recommended for self-hosting.

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

@IAmTomahawkx
Copy link
Member

Given the impending new voice server is almost complete, I don't think we want to provide people with any sort of guidance for Vortex, even if it is clear that it's unsupported. The livekit system will ideally be fully supported in self-hosted, and guiding people to move over is going to be annoying/problematic.

@lkuechler
Copy link
Contributor Author

That's very good news and I am looking forward to it. I think it would still make sense to inform people that this guide will not provide them with a revolt setup that has voice-chats enabled. Since it can be a bit frustrating to go through the setup to just find out later, from a closed ticket, that this is currently not included. :)

I updated the changes to reflect your comment. Thanks again for working on this project

Copy link
Contributor

@insertish insertish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation bot moved this from 🆕 Untriaged to 💡 Ready to merge in Pull Request Overview Apr 25, 2025
@insertish insertish merged commit bb044eb into stoatchat:master Apr 25, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from 💡 Ready to merge to ✅ Merged in Pull Request Overview Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants