-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$stateChangeSuccess are now deprecated and disabled by default #220
Comments
yep, we need some patch to handle that; |
Waiting for this too... |
@revolunet Perhaps it is time we stopped having ui-router (or ng-router) specific behaviors in the library and instead offer how to set it up as part of the documentation (it is pretty trivial stuff to setup). ui-router deprecating a feature should not require this library to update its version. |
Hi ! i cant really say whats good anymore as i dont use angular much..... but yes, if deprecated, we should to that 👍 |
I am using the new version of ui-router (1.0.13 to be exact) and library is still operational. @hbdbim have you experienced / are you experiencing issues or you are only afraid you might do so in near future? |
Hello ! I had a related problem using ui-router 1.0.15. Nothing was sent to GA when changing page. Digging further, ui-router switched from $stateChangeSuccess In the meantime I created a small working module inspired from : https://dev.to/jordanirabor/using-google-analytics-with-angular-930 |
what now!?
https://ui-router.github.io/guide/ng1/migrate-to-1_0#state-change-events
The text was updated successfully, but these errors were encountered: