Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$stateChangeSuccess are now deprecated and disabled by default #220

Open
hbdbim opened this issue Jan 18, 2018 · 6 comments
Open

$stateChangeSuccess are now deprecated and disabled by default #220

hbdbim opened this issue Jan 18, 2018 · 6 comments

Comments

@hbdbim
Copy link

hbdbim commented Jan 18, 2018

what now!?

https://ui-router.github.io/guide/ng1/migrate-to-1_0#state-change-events

@revolunet
Copy link
Owner

yep, we need some patch to handle that;

@feelitloveit
Copy link

Waiting for this too...

@justinsa
Copy link
Collaborator

justinsa commented Mar 5, 2018

@revolunet Perhaps it is time we stopped having ui-router (or ng-router) specific behaviors in the library and instead offer how to set it up as part of the documentation (it is pretty trivial stuff to setup). ui-router deprecating a feature should not require this library to update its version.

@revolunet
Copy link
Owner

Hi ! i cant really say whats good anymore as i dont use angular much..... but yes, if deprecated, we should to that 👍

@Rasha-Dj
Copy link

I am using the new version of ui-router (1.0.13 to be exact) and library is still operational. @hbdbim have you experienced / are you experiencing issues or you are only afraid you might do so in near future?

@lsioctl
Copy link

lsioctl commented Jun 1, 2018

Hello !

I had a related problem using ui-router 1.0.15. Nothing was sent to GA when changing page. Digging further, ui-router switched from

$stateChangeSuccess
to
$transitions.onSuccess

In the meantime I created a small working module inspired from :

https://dev.to/jordanirabor/using-google-analytics-with-angular-930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants