Problems with stack on run(model)

[jrising]

I am working with a PhD student, and on her machine the MimiGIVE model does not run because of an error from MimiRFFSPs. The error claims that stack is exported by Base. I think this comes from the new version of Julia, because I don't think my Base includes a stack function. Here's the error:

WARNING: both DataFrames and Base export "stack"; uses of it in module MimiRFFSPs must be qualified
ERROR: UndefVarError: `stack` not defined
Stacktrace:
  [1] (::MimiRFFSPs.var"#3#7")(i::DataFrames.DataFrame)
    @ MimiRFFSPs C:\Users\Deepak\.julia\packages\MimiRFFSPs\J6wRq\src\components\SPs.jl:153
  [2] |>
    @ .\operators.jl:907 [inlined]
...

Are there version limits with MimiRFFSPs?

[lrennels]

Hi @jrising so sorry for the delay on this, I haven't run into this problem and am on Julia 1.8, is she on 1.9? RIght now I believe the combat for MimiRFFSPs and MimiGIVE does say Julia 1.6, which makes it compatible with anything above 1.6 (unless I'm getting my semantic versioning rules wrong) -- @davidanthoff and I will look into this and get back to you quickly.

[lrennels]

I did see this is in Julia 1.9 so that's probably what's going on here.

New function stack(x) which generalises reduce(hcat, x::Vector{<:Vector}) to any dimensionality, and allows any iterator of iterators. Method stack(f, x) generalises mapreduce(f, hcat, x) and is more efficient (#43334).

[lrennels]

@jrising I think this PR should help #40 unless you have a more clever way to prioritize the DataFrames stack function over Julia. I can merge it and then MimiGIVE should pull in the new version.

[jrising]

@lrennels Your PR looks like it does just what's needed. Thanks.

[lrennels]

Great thank you @jrising just one of the 15 test configurations are failing right now, likely due to some CI issue but I'm going to wait until those go through before merging

[lrennels]

Done #40 and tagging new version (patch) v1.1.1